Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing response models to openapi.json #91

Closed
ehclark opened this issue Apr 18, 2024 · 2 comments · Fixed by #95
Closed

Add back missing response models to openapi.json #91

ehclark opened this issue Apr 18, 2024 · 2 comments · Fixed by #95
Assignees

Comments

@ehclark
Copy link
Contributor

ehclark commented Apr 18, 2024

Split off from #85

Same underlying problem as cancervariants/variation-normalization#543

Changed the response models to return Dict instead of the types from ga4gh.vrs.models. This allows the full, dereferenced VRS object to be returned from the API endpoints instead of the version produced by the serialization logic embedded in the model hierarchy.

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 18, 2024
@jsstevenson
Copy link
Contributor

Closing in on a resolution in ga4gh/vrs-python#435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants