-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add r-base as a dependency #16398
Add r-base as a dependency #16398
Conversation
r-base is needed for picard CollectMultipleMetrics, CollectInsertSizeMetrics etc. (basically anything with metrics).
#3859 :( |
@bgruening. I posted my opinion on the issue. |
@bgruening , given that there was no great backlash on the issue, I think that nobody strongly cares about this. Shall we go ahead and merge this? |
@dpryan79 any opinion? |
I’m a very weak “no” on this. Picard is just so bloated as is and I have to say this is the first time I’d heard that Picard did any plotting on this.
…Sent from my iPhone
On 2. Aug 2019, at 17:26, Björn Grüning ***@***.***> wrote:
@dpryan79 any opinion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I tend to agree that things should work out of the box, although I have to admit I shared Devon's unawareness regarding the R dependency. Given the bloat having a |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
@bgruening @dpryan79 @cbrueffer Is this compromise to your liking? EDIT: Also updated the branch with master. |
👍 from me. @bgruening @cbrueffer thoughts? |
Looks good; a post-install message in each of the recipes pointing to the other one would be nice ("A package without the R dependency is available as |
Fine with me ... |
@cbrueffer I do agree that users need to be notified. While working on the post-link script however, I felt that I had to write a really, really good message that would be worth it for the user to see every time they install picard. This is IMO not possible. It is a very annoying way to let users know. I have added information about picard and picard-slim to the package descriptions, so that users can make an informed decision on which package to install based on the information on bioconda.github.io. If these descriptions are okay I will merge the branch. |
Thanks @rhpvorderman , I like the idea. |
* Add r-base as a dependency r-base is needed for picard CollectMultipleMetrics, CollectInsertSizeMetrics etc. (basically anything with metrics). * sanitize input * add picard-slim package * remove unnecessary python dependency * better descriptions.
Can this be added to the gatk4 as a dependency as well? |
r-base is needed for picard CollectMultipleMetrics, CollectInsertSizeMetrics etc. (basically anything with metrics).