Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: moFF: Pandas version limited to <1.0.0 in order to avoid problems using .ix… #21956

Merged
merged 1 commit into from
May 5, 2020

Conversation

CarlosHorro
Copy link
Contributor

@CarlosHorro CarlosHorro commented May 5, 2020

… (removed from pandas 1.0.0 and above).

There is currently a problem when executing moFF caused by an update of Pandas library. My execution of moFF gives an error like this:

Starting Apex for ./ident_inputs/Label-PSM-ToDelete.raw ... moff Input file: ./ident_inputs/Label-PSM-ToDelete.raw XIC_tol 10.0 XIC_win 3.0000 moff_rtWin_peak 1.0000 RAW file : ['./raws/qExactive01819.raw.raw'] Output file in : ./out starting peptide quantification (ms2 / matched ) .. Traceback (most recent call last): File "/home/carlos/GitHub/galaxy/database/dependencies/_conda/envs/__moff@2.0.2/share/moff-2.0.2-2/moff.py", line 870, in apex_multithr temp.ix[:, 'tol'] = int(tol) File "/home/carlos/GitHub/galaxy/database/dependencies/_conda/envs/__moff@2.0.2/lib/python3.6/site-packages/pandas/core/generic.py", line 5274, in __getattr__ return object.__getattribute__(self, name) AttributeError: 'DataFrame' object has no attribute ix

This is due to the fact that pandas 1.0.0 has removed support for DataFrame.ix , and all installations later than 2020/01/30 will install Pandas 1.0.0 instead of the previous ones which just showed a warning (pandas-dev/pandas#26438) about the future (now present) removal of it.

So, whilst new indexes replace old .ix, I suggest to limit pandas version prior to 1.0.0 in order to avoid execution errors running moFF.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@bgruening bgruening merged commit cc7df4a into bioconda:master May 5, 2020
@CarlosHorro CarlosHorro deleted the moff_pandas branch May 6, 2020 07:55
a-solovyev12 pushed a commit to ebi-gene-expression-group/bioconda-recipes that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants