Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiQC v1.13a0 #35523

Merged
merged 7 commits into from
Jun 27, 2022
Merged

MultiQC v1.13a0 #35523

merged 7 commits into from
Jun 27, 2022

Conversation

apeltzer
Copy link
Member

(dev version) with bugfixes for mirtop… … and Dupradar

Describe your pull request here

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@apeltzer apeltzer requested a review from ewels June 27, 2022 12:14
@apeltzer apeltzer self-assigned this Jun 27, 2022
ewels
ewels approved these changes Jun 27, 2022
View reviewed changes
recipes/multiqc/meta.yaml Outdated Show resolved Hide resolved
ewels
ewels approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@apeltzer
Copy link
Member Author

Any idea @ewels ? Something about module not being callable - just added rich-click... which is required now?

@apeltzer
Copy link
Member Author

@bioconda/python -- any idea why the module import does not work?

@apeltzer
Copy link
Member Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jun 27, 2022
@apeltzer
Copy link
Member Author

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit b741279 into bioconda:master Jun 27, 2022
@apeltzer apeltzer deleted the mqc-dev branch June 27, 2022 14:35
@bgruening
Copy link
Member

dev version makes me nervouis. Please note that people will get this version by default if they do not specify a version. Those version should be stable imho.

@apeltzer
Copy link
Member Author

This dev release is stable + two bugfixes and @ewels and I discussed to have a release as the bugs were really bugging a couple of people ;-) Will definitely release a 1.13 full release once there is a final release asap.

@ewels
Copy link
Member

ewels commented Jun 28, 2022

Or... ok maybe not so stable. Looks like this is failing with something odd-sounding from the Conda build. Follow-up PR: #35553

jpfeuffer pushed a commit to OpenMS/bioconda-recipes that referenced this pull request Sep 7, 2022
@apeltzer
[ci skip] Merge PR 35523
a8691c9 
Merge PR bioconda#35523, commits were: 
 * Drop regular tests - we test the modules already
 * Merge branch 'mqc-dev' of https://github.com/apeltzer/bioconda-recipes into mqc-dev
 * Add Rich Click
 * Merge branch 'master' into mqc-dev
 * URL from main repository
 * use direct url, had to make an archive
 * Started adding MultiQC v1.13a0 (dev version) with bugfixes for mirtop and Dupradar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees

@apeltzer apeltzer

Labels
please review & merge set to ask for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apeltzer @BiocondaBot @bgruening @ewels