Pegas #49759
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| {% set name = "pegas" %} | ||
| {% set version = "0.2.13" %} | ||
|
|
||
| package: | ||
| name: {{ name }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://github.com/liviurotiul/PeGAS/archive/refs/tags/v{{ version }}.tar.gz | ||
| sha256: 2c028caa90bb8825e1c64f2ca5bd5e80f82f6db1cb5c4609bed86157c954c1f8 | ||
|
|
||
| build: | ||
| number: 0 | ||
| noarch: python | ||
| script: "{{ PYTHON }} -m pip install ." | ||
| run_exports: | ||
| - {{ pin_subpackage(name, max_pin="x") }} | ||
|
|
||
| requirements: | ||
| build: | ||
| - python | ||
| - pip | ||
| - setuptools | ||
|
|
||
| run: | ||
| - python=3.10 | ||
| - plotly ~=5.0.0 | ||
| - pandas ~=1.3.5 | ||
| - tqdm ~=4.66.5 | ||
| - matplotlib-base ~=3.9.2 | ||
| - networkx ~=3.2 | ||
| - snakemake ~=7.32.4 | ||
| - beautifulsoup4 ~=4.12.3 | ||
liviurotiul marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test: | ||
| commands: | ||
| - {{ name }} --help | ||
|
Comment on lines
+34
to
+36
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance test coverage for better package validation. While running the help command is a good basic test to ensure the package is installed correctly, it doesn't verify the package's functionality. Consider adding more comprehensive tests, such as:
For example: test:
commands:
- {{ name }} --help
- {{ name }} --version
- python -c "from pegas import some_key_function; assert some_key_function() == expected_output"
files:
- path/to/test/data/sample.fastqThese additional tests would provide more confidence in the package's functionality after installation. Please adjust the suggested tests according to your package's specific features and requirements. |
||
|
|
||
| about: | ||
| home: https://github.com/liviurotiul/PeGAS | ||
| license: GPL-2.0 | ||
|
There was a problem hiding this comment. Please use id from https://spdx.org/licenses/ |
||
| license_family: GPL | ||
| license_file: LICENSE | ||
| summary: "PeGAS is a Snakemake pipeline for genome analysis" | ||
| description: | | ||
| PeGAS is a Snakemake pipeline for genome analysis. It is designed to be | ||
| lightweight, easy to install, and easy to use. | ||
| doc_url: https://github.com/liviurotiul/PeGAS#readme | ||
| dev_url: https://github.com/liviurotiul/PeGAS/issues | ||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - liviurotiul | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove unnecessary run_exports section.
The build configuration looks good overall, but as mentioned in a previous comment, the
run_exportssection is typically not necessary for pure Python packages. This section is more commonly used for compiled libraries to ensure ABI compatibility.Consider removing the
run_exportssection:build: number: 0 noarch: python script: "{{ PYTHON }} -m pip install ." - run_exports: - - {{ pin_subpackage(name, max_pin="x") }}This simplification aligns better with typical Python package recipes in Conda-Forge and Bioconda.
📝 Committable suggestion