-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vclust #50007
Add vclust #50007
Changes from 42 commits
a1be063
3483446
fe5b8cb
cd3cf3b
8053c21
a7cda1c
36a3493
adb09d0
6807355
e226d4f
3b35243
6b1f9d0
26e9663
e2fac12
0cc018f
1b0e520
7f3ae8f
b047f94
f1366fb
fc81b0a
3a0f008
08b4671
2d51c8a
8237f48
51358ac
279c3a6
4ba92d1
8e27483
2b99478
ba9f896
9112445
f8efee2
040c953
56d6ed0
2b5e210
531305a
2e05d37
44d9de4
c0ecde6
1748cf1
1f16f5d
a406834
e930050
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
{% set version = "1.2.7" %} | ||
|
||
{% set system = "x64_linux" %} # [linux and x86_64] | ||
{% set system = "x64_mac" %} # [osx and x86_64] | ||
{% set system = "arm64_linux" %} # [linux and aarch64] | ||
{% set system = "arm64_mac" %} # [osx and arm64] | ||
|
||
{% set sha256 = "5f750bd1bfc8448d127ea8a566860bc10c58c768a79d3d9a814243d64c1f16cf" %} # [linux and x86_64] | ||
{% set sha256 = "077a44e14e429a526868ca16364c62b800eeade9aa7df184fdda8f93e053c356" %} # [osx and x86_64] | ||
{% set sha256 = "9b2b410607d26ec05b1bdc42329b73285e4a862c93f67aff6c157b10b02e3383" %} # [linux and aarch64] | ||
{% set sha256 = "b917c5af92e806b4244a62a32063c81bc9de3eae3760498444398fe7c5a7f623" %} # [osx and arm64] | ||
|
||
|
||
package: | ||
name: vclust | ||
version: {{ version }} | ||
|
||
build: | ||
number: 0 | ||
run_exports: | ||
- {{ pin_subpackage('vclust', max_pin='x') }} | ||
script: | | ||
mkdir -p ${PREFIX}/bin | ||
cp -r vclust.py bin ${PREFIX}/bin/ | ||
chmod +x ${PREFIX}/bin/vclust.py | ||
|
||
source: | ||
url: https://github.com/refresh-bio/vclust/releases/download/v{{ version }}/vclust-v{{ version }}-{{ system }}.tar.gz | ||
sha256: {{ sha256 }} | ||
|
||
requirements: | ||
host: | ||
- python >=3.7 | ||
run: | ||
- python >=3.7 | ||
|
||
about: | ||
home: https://github.com/refresh-bio/vclust | ||
summary: "Fast and accurate tool for calculating ANI and clustering virus genomes and metagenomes." | ||
license: GPL-3.0-or-later | ||
license_family: GPL3 | ||
|
||
test: | ||
#source_files: | ||
# - example/*.* | ||
# - example/output/*.* | ||
#requires: | ||
# - pytest | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove the commented out lines |
||
commands: | ||
- vclust.py --help | ||
- vclust.py info | ||
#- vclust.py prefilter -i example/multifasta.fna -o tmp/filter.txt --batch-size 4 --k 18 | ||
#- cmp tmp/filter.txt example/output/fltr.txt | ||
#- vclust.py align -i example/multifasta.fna -o tmp/ani.tsv | ||
#- cmp tmp/ani.tsv example/output/ani.tsv | ||
#- vclust.py cluster -i tmp/ani.tsv -o tmp/clusters.tsv --ids tmp/ani.ids.tsv --tani 0.95 | ||
#- cmp tmp/clusters.tsv example/output/clusters.tsv | ||
#- pytest test.py # [linux] | ||
#- pytest test.py -k 'not test_cluster_algorithm_leiden' # [osx] | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Review and update the test section. The test section includes a mix of active and commented-out commands. While the active commands check basic functionality, which aligns with the PR objective of distributing precompiled libraries temporarily, consider the following:
Example of potential updates: test:
commands:
- vclust.py --help
- vclust.py info
- vclust.py prefilter -i example/multifasta.fna -o tmp/filter.txt --batch-size 4 --k 18
- cmp tmp/filter.txt example/output/fltr.txt
# Add more relevant tests here Please review and update the test section accordingly to ensure comprehensive testing of the precompiled libraries. |
||
extra: | ||
additional-platforms: | ||
- linux-aarch64 | ||
- osx-arm64 | ||
skip-lints: | ||
- should_be_noarch_generic | ||
- should_not_be_noarch_source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider adding pytest to host requirements.
The Python requirement is correctly specified for both host and run environments. However, as pytest is used in the test section (although currently commented out), it should be added to the host requirements to ensure it's available during package building and testing.
Add pytest to the host requirements:
This change will help prevent potential issues during package testing.