Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vclust #50007

Merged
merged 43 commits into from
Oct 16, 2024
Merged
Changes from 42 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
a1be063
add vclust
agudys Aug 13, 2024
3483446
fix
agudys Aug 13, 2024
fe5b8cb
Build version reset
agudys Aug 13, 2024
cd3cf3b
fix
agudys Aug 13, 2024
8053c21
another one
agudys Aug 13, 2024
a7cda1c
next one
agudys Aug 13, 2024
36a3493
fix?
agudys Aug 13, 2024
adb09d0
added build.sh
agudys Aug 13, 2024
6807355
build.sh removed
agudys Aug 13, 2024
e226d4f
another try
agudys Aug 13, 2024
3b35243
final?
agudys Aug 13, 2024
6b1f9d0
not really
agudys Aug 13, 2024
26e9663
check
agudys Aug 13, 2024
e2fac12
maybe final?
agudys Aug 13, 2024
0cc018f
debug info
agudys Aug 13, 2024
1b0e520
debug
agudys Aug 13, 2024
7f3ae8f
fix
agudys Aug 13, 2024
b047f94
fix?
agudys Aug 13, 2024
f1366fb
again
agudys Aug 13, 2024
fc81b0a
fix
agudys Aug 13, 2024
3a0f008
dummy change to rerun workflow
agudys Aug 30, 2024
08b4671
update
agudys Oct 5, 2024
2d51c8a
fix
agudys Oct 5, 2024
8237f48
fix
agudys Oct 5, 2024
51358ac
ix
agudys Oct 5, 2024
279c3a6
fix
agudys Oct 5, 2024
4ba92d1
fix
agudys Oct 6, 2024
8e27483
let's see
agudys Oct 12, 2024
2b99478
chmod
agudys Oct 12, 2024
ba9f896
fix
agudys Oct 12, 2024
9112445
will see
agudys Oct 12, 2024
f8efee2
shell test
agudys Oct 12, 2024
040c953
test
agudys Oct 12, 2024
56d6ed0
abc
agudys Oct 12, 2024
2b5e210
d
agudys Oct 12, 2024
531305a
updated revision
agudys Oct 14, 2024
2e05d37
sha fix
agudys Oct 14, 2024
44d9de4
debug info
agudys Oct 14, 2024
c0ecde6
Update recipes/vclust/meta.yaml
agudys Oct 16, 2024
1748cf1
hopefully final commit
agudys Oct 16, 2024
1f16f5d
Merge branch 'add-vclust' of https://github.com/agudys/bioconda-recip…
agudys Oct 16, 2024
a406834
Update license family
martin-g Oct 16, 2024
e930050
Removed commented lines
agudys Oct 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions recipes/vclust/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
{% set version = "1.2.7" %}

{% set system = "x64_linux" %} # [linux and x86_64]
{% set system = "x64_mac" %} # [osx and x86_64]
{% set system = "arm64_linux" %} # [linux and aarch64]
{% set system = "arm64_mac" %} # [osx and arm64]

{% set sha256 = "5f750bd1bfc8448d127ea8a566860bc10c58c768a79d3d9a814243d64c1f16cf" %} # [linux and x86_64]
{% set sha256 = "077a44e14e429a526868ca16364c62b800eeade9aa7df184fdda8f93e053c356" %} # [osx and x86_64]
{% set sha256 = "9b2b410607d26ec05b1bdc42329b73285e4a862c93f67aff6c157b10b02e3383" %} # [linux and aarch64]
{% set sha256 = "b917c5af92e806b4244a62a32063c81bc9de3eae3760498444398fe7c5a7f623" %} # [osx and arm64]


package:
name: vclust
version: {{ version }}

build:
number: 0
run_exports:
- {{ pin_subpackage('vclust', max_pin='x') }}
script: |
mkdir -p ${PREFIX}/bin
cp -r vclust.py bin ${PREFIX}/bin/
chmod +x ${PREFIX}/bin/vclust.py

source:
url: https://github.com/refresh-bio/vclust/releases/download/v{{ version }}/vclust-v{{ version }}-{{ system }}.tar.gz
sha256: {{ sha256 }}

requirements:
host:
- python >=3.7
run:
- python >=3.7
Comment on lines +31 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding pytest to host requirements.

The Python requirement is correctly specified for both host and run environments. However, as pytest is used in the test section (although currently commented out), it should be added to the host requirements to ensure it's available during package building and testing.

Add pytest to the host requirements:

requirements:
  host:
    - python >=3.7
    - pytest
  run:
    - python >=3.7

This change will help prevent potential issues during package testing.


about:
home: https://github.com/refresh-bio/vclust
summary: "Fast and accurate tool for calculating ANI and clustering virus genomes and metagenomes."
license: GPL-3.0-or-later
license_family: GPL3

test:
#source_files:
# - example/*.*
# - example/output/*.*
#requires:
# - pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented out lines

commands:
- vclust.py --help
- vclust.py info
#- vclust.py prefilter -i example/multifasta.fna -o tmp/filter.txt --batch-size 4 --k 18
#- cmp tmp/filter.txt example/output/fltr.txt
#- vclust.py align -i example/multifasta.fna -o tmp/ani.tsv
#- cmp tmp/ani.tsv example/output/ani.tsv
#- vclust.py cluster -i tmp/ani.tsv -o tmp/clusters.tsv --ids tmp/ani.ids.tsv --tani 0.95
#- cmp tmp/clusters.tsv example/output/clusters.tsv
#- pytest test.py # [linux]
#- pytest test.py -k 'not test_cluster_algorithm_leiden' # [osx]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Review and update the test section.

The test section includes a mix of active and commented-out commands. While the active commands check basic functionality, which aligns with the PR objective of distributing precompiled libraries temporarily, consider the following:

  1. Uncomment and enable additional test commands if they are applicable to the precompiled libraries.
  2. If some tests are not applicable to the current distribution method, consider removing them to improve clarity.
  3. Ensure that any uncommented tests will work with the precompiled binaries.

Example of potential updates:

test:
  commands:
    - vclust.py --help
    - vclust.py info
    - vclust.py prefilter -i example/multifasta.fna -o tmp/filter.txt --batch-size 4 --k 18
    - cmp tmp/filter.txt example/output/fltr.txt
    # Add more relevant tests here

Please review and update the test section accordingly to ensure comprehensive testing of the precompiled libraries.

extra:
additional-platforms:
- linux-aarch64
- osx-arm64
skip-lints:
- should_be_noarch_generic
- should_not_be_noarch_source