-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gget to 0.29.0 #50960
Update gget to 0.29.0 #50960
Conversation
📝 WalkthroughWalkthroughThe Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/gget/meta.yaml (1)
78-79
: DOI identifier addition approved with a suggestion.The addition of the DOI identifier is excellent as it enhances the metadata and improves the discoverability and citability of the package.
Consider adding a comment above the DOI to indicate what it refers to, for example:
identifiers: # DOI for the gget publication - doi:10.1093/bioinformatics/btac836This will provide more context for future maintainers and users of the recipe.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/gget/meta.yaml (4 hunks)
🔇 Additional comments (4)
recipes/gget/meta.yaml (4)
2-3
: Version and checksum update looks good.The package version has been correctly updated to 0.29.0, and the SHA256 checksum has been updated accordingly. These changes are consistent with the PR objectives.
66-66
: Summary formatting improvement approved.The addition of a period at the end of the summary improves its formatting and consistency.
30-30
: Verify mysql-connector-python version requirement change.The mysql-connector-python version requirement has been updated from
>=8.0.5,<=8.0.29
to>=8.0.32
. This change significantly increases the minimum version and removes the upper bound constraint.Please confirm if this change is intentional and required. Consider the following:
- Are there specific features or bug fixes in mysql-connector-python 8.0.32 that are necessary for gget 0.29.0?
- Is it safe to remove the upper bound constraint? This might lead to compatibility issues with future versions of mysql-connector-python.
You can run the following script to check if the change is mentioned in the release notes:
Also applies to: 43-43
24-24
: Verify Python version requirement change.The minimum Python version requirement has been increased from 3.6 to 3.7. While this change might be necessary for new features or dependencies in gget 0.29.0, it could potentially break compatibility for users still using Python 3.6.
Please confirm if this change is intentional and required. You can run the following script to check if the change is mentioned in the release notes:
Also applies to: 37-37
No artifacts found on the most recent builds. Either the builds failed, the artifacts have been removed due to age, or the recipe was blacklisted/skipped. |
Update
gget
: 0.28.6 → 0.29.0recipes/gget
(click to view/edit other files)@pachterlab
This pull request was automatically generated (see docs).