-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyPINTS to 1.1.13 #51056
Update pyPINTS to 1.1.13 #51056
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
recipes/pypints/meta.yaml (2)
9-9
: Source URL update is correct, but could be more maintainable.The updated URL correctly points to the new version's tarball on PyPI. However, for easier maintenance in future updates, consider using a templated URL.
Consider using a templated URL for easier maintenance:
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"This way, you only need to update the version number for future releases.
Line range hint
1-58
: Overall, the update looks good with some good practices in place.The update correctly maintains the build number at 0 for a version change, and includes a
run_exports
section as recommended in the PR instructions. This helps prevent API/ABI breakage issues.One minor suggestion for improvement:
Consider adding a
build
section to therun_exports
to specify the minimum version:run_exports: - {{ pin_subpackage('pypints', max_pin='x', min_pin='x.x') }}This ensures that downstream packages will require at least this minor version, which can help prevent issues if there are any minor API changes.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/pypints/meta.yaml (1 hunks)
🔇 Additional comments (2)
recipes/pypints/meta.yaml (2)
2-2
: Version update looks good.The version has been correctly updated to 1.1.13, which aligns with the PR objective.
10-10
: SHA256 checksum has been updated.The SHA256 checksum has been changed, which is expected with a new version. However, it's crucial to verify its correctness.
Please run the following script to verify the SHA256 checksum:
Please ensure that the calculated checksum matches the one in the meta.yaml file.
Update pyPINTS to 1.1.13
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.Summary by CodeRabbit
New Features
pyPINTS
package to version1.1.13
, providing users with the latest enhancements and fixes.Bug Fixes