-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hsdecipher script #51057
Update Hsdecipher script #51057
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/hsdecipher/meta.yaml (1 hunks)
🔇 Additional comments (3)
recipes/hsdecipher/meta.yaml (3)
13-13
: Build number increment is correct.The build number has been properly incremented from 1 to 2. This is the correct practice when updating a package, as it allows for tracking different builds of the same version.
Line range hint
1-38
: Overall changes are consistent and well-implemented.The updates to the meta.yaml file are consistent with a minor version update:
- Version has been incremented from 1.0.0 to 1.1.1.
- SHA256 checksum has been updated accordingly.
- Build number has been incremented.
The presence of the
run_exports
section is commendable, as it aligns with the PR objectives regarding dependency version management. Runtime requirements, test commands, and metadata remain unchanged, which is appropriate for a minor version update.🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
2-2
: Version update looks good.The version has been correctly updated from "1.0.0" to "1.1.1", following semantic versioning principles. This is consistent with the PR objective to update the Hsdecipher script.
Please ensure that this version update is reflected in other relevant files or documentation. Run the following script to check for any inconsistencies:
|
||
package: | ||
name: {{ name|lower }} | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/zx0223winner/{{name|lower}}_conda/archive/refs/tags/v{{version}}.tar.gz | ||
sha256: 54ab84f8584c69a50db4678b49279b0a0b4b05cf0028eec9c2f2ea2205917b76 | ||
sha256: 7ac882c835b53a78e4dfe5120037a8237f5e79a5ab94d7d0edd893d5851007ba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Checksum Verification Failed
The verification script could not compute the SHA256 checksum because the sha256sum
command is unavailable. Please update the script to use openssl
for checksum calculation:
#!/bin/bash
# Description: Verify the SHA256 checksum of the source archive
# Extract version and checksum from meta.yaml
version=$(grep 'version = ' recipes/hsdecipher/meta.yaml | cut -d '"' -f 2)
expected_checksum=$(grep 'sha256: ' recipes/hsdecipher/meta.yaml | cut -d ' ' -f 4)
# Download the archive
curl -L "https://github.com/zx0223winner/hsdecipher_conda/archive/refs/tags/v${version}.tar.gz" -o hsdecipher.tar.gz
# Compute the checksum using openssl
computed_checksum=$(openssl dgst -sha256 hsdecipher.tar.gz | awk '{print $2}')
# Compare checksums
echo "Expected checksum: $expected_checksum"
echo "Computed checksum: $computed_checksum"
if [ "$expected_checksum" = "$computed_checksum" ]; then
echo "Checksums match."
else
echo "Checksums do not match!"
fi
# Clean up
rm hsdecipher.tar.gz
🔗 Analysis chain
SHA256 checksum has been updated.
The SHA256 checksum has been updated, which is necessary due to the version change. This ensures the integrity of the downloaded package.
To ensure the correctness of the new checksum, please verify it against the source archive. You can use the following script to download the archive and compute its checksum:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the SHA256 checksum of the source archive
# Extract version and checksum from meta.yaml
version=$(grep 'version = ' recipes/hsdecipher/meta.yaml | cut -d '"' -f 2)
expected_checksum=$(grep 'sha256: ' recipes/hsdecipher/meta.yaml | cut -d ' ' -f 4)
# Download the archive
curl -L "https://github.com/zx0223winner/hsdecipher_conda/archive/refs/tags/v${version}.tar.gz" -o hsdecipher.tar.gz
# Compute the checksum
computed_checksum=$(sha256sum hsdecipher.tar.gz | cut -d ' ' -f 1)
# Compare checksums
echo "Expected checksum: $expected_checksum"
echo "Computed checksum: $computed_checksum"
if [ "$expected_checksum" = "$computed_checksum" ]; then
echo "Checksums match."
else
echo "Checksums do not match!"
fi
# Clean up
rm hsdecipher.tar.gz
Length of output: 1280
@BiocondaBot please add label |
Describe your pull request here
update the script
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.Summary by CodeRabbit
New Features
Bug Fixes
Documentation