-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
galaxy_sequence_util: pin python #51102
Conversation
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe changes involve updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/galaxy_sequence_utils/meta.yaml (1)
43-44
: Approve Python version constraint, but suggest applying it to both environments.The addition of the Python version constraint (
<3.12
) is a good proactive measure to prevent compatibility issues due to the deprecation of theimp
module in Python 3.12. The comment clearly explains the reasoning behind this constraint.However, for consistency and to ensure the package runs in a compatible environment, consider applying this constraint to both the
host
andrun
environments.Apply the following change to the
run
environment as well:run: - - python + - python <3.12 - six
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/galaxy_sequence_utils/meta.yaml (2 hunks)
🔇 Additional comments (2)
recipes/galaxy_sequence_utils/meta.yaml (2)
21-21
: LGTM: Build number increment is appropriate.The build number has been correctly incremented from 1 to 2. This is the proper approach when making changes to a package without altering its version number.
Line range hint
1-58
: Summary: Changes align with PR objectives, with a minor suggestion for improvement.The modifications in this PR successfully implement version pinning for Python in the
galaxy_sequence_utils
recipe, aligning with the stated objectives. The build number increment and the addition of a Python version constraint are appropriate changes that enhance the stability and reliability of the package.To fully meet the PR objectives and ensure consistency:
- The Python version constraint has been correctly added to the
host
environment.- Consider applying the same constraint (
<3.12
) to therun
environment as well.These changes collectively address the goal of preventing potential issues arising from future changes in dependencies, particularly with respect to Python versions.
dd08828
to
187b362
Compare
@BiocondaBot please add label |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.Summary by CodeRabbit
New Features
galaxy_sequence_utils
package to support Python versions less than 3.12.Bug Fixes