-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update piawka to 0.8.2 #51259
Update piawka to 0.8.2 #51259
Conversation
📝 WalkthroughWalkthroughThis pull request introduces an update to the Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/piawka/meta.yaml (1)
23-23
: Remove trailing spaces.There are trailing spaces on lines 23, 35, 36, and 42. While they don't affect functionality, it's good practice to remove them for consistency and cleanliness.
You can remove the trailing spaces from these lines:
- Line 23 (after
tabix
)- Line 35 (after
π, Dxy (or πxy, or Nei's D)
)- Line 36 (after
and some more simple stats (Fst, Tajima's D, Ronfort's rho) in VCF files in the command line.
)- Line 42 (empty line with spaces)
Also applies to: 35-36, 42-42
🧰 Tools
🪛 yamllint
[error] 23-23: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/piawka/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/piawka/meta.yaml
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 42-42: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
recipes/piawka/meta.yaml (3)
2-2
: Version update looks good.The version has been correctly updated to 0.8.2, which aligns with the PR objective.
1-45
: Overall, the changes look good.The update from version 0.8.1 to 0.8.2 has been correctly implemented in the meta.yaml file. The version number and SHA256 checksum have been updated as expected. The rest of the file remains unchanged, which is appropriate for a minor version update.
A few minor suggestions:
- Verify the SHA256 checksum to ensure it matches the new version's tarball.
- Remove trailing spaces as mentioned in the previous comment.
Once these small items are addressed, the update should be ready to merge.
🧰 Tools
🪛 yamllint
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
[error] 35-35: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 42-42: trailing spaces
(trailing-spaces)
10-10
: Verify the SHA256 checksum.The SHA256 checksum has been updated for the new version. It's crucial to ensure this checksum is correct for version 0.8.2 of the piawka package.
To verify the checksum, you can run the following script:
Update
piawka
: 0.8.1 → 0.8.2recipes/piawka
(click to view/edit other files)@novikovalab
This pull request was automatically generated (see docs).