Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new trim-galore build #51563

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Make a new trim-galore build #51563

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26dc84d
Make a new trim-galore build
pinin4fjords Oct 22, 2024
246c14f
add run_exports
pinin4fjords Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipes/trim-galore/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ source:
sha256: '{{sha256}}'

build:
number: 0
number: 1
noarch: generic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding a run_exports section.

To better manage dependencies and prevent potential API, ABI, and CLI breakage issues, consider adding a run_exports section to the build section. This would ensure that the dependency versions used at build time are recorded and locked. For example:

build:
  number: 1
  noarch: generic
  run_exports:
    - {{ pin_subpackage('trim-galore', max_pin='x.x') }}

This addition aligns with the PR objectives and Bioconda best practices.

requirements:
Expand Down
Loading