Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macsyfinder dependencies #51599

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

bneron
Copy link
Contributor

@bneron bneron commented Oct 23, 2024

add setuptools for build
relax versions for pandas, hmmer dependencies

add setuptools for build
relax versions for pandas, hmmer dependencies
Copy link
Contributor

coderabbitai bot commented Oct 23, 2024

📝 Walkthrough

Walkthrough

The pull request modifies the meta.yaml file for the macsyfinder package. Key changes include an update to the build number from 0 to 1, indicating a new build iteration. The requirements section has been enhanced by adding setuptools as a host requirement. Additionally, the version constraints for the pandas and hmmer packages have been revised: pandas has been updated from <=1.5.1 to <=2.2.3, and hmmer has been updated from <=3.3.2 to <=3.4. These modifications reflect adjustments to dependencies and their version limits, which may influence compatibility and functionality of the package.

Possibly related PRs

  • Update Hsdfinder script #51058: This PR updates the meta.yaml file for the HSDFinder package, which includes a change to the build number and updates to the version number, similar to the changes made in the main PR for the macsyfinder package.
  • Update Hsdfinder #51092: This PR also updates the HSDFinder package's meta.yaml, including changes to the build number and version number, aligning with the updates made in the main PR.
  • Update assembly_finder recipe #51449: This PR updates the meta.yaml files for both the assembly_finder and "MeSS" packages, which includes changes to the build number and the addition of setuptools as a host requirement, similar to the main PR's updates.

Suggested labels

please review & merge

Suggested reviewers

  • martin-g

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9b88759 and 48a2622.

📒 Files selected for processing (1)
  • recipes/macsyfinder/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (5)
recipes/macsyfinder/meta.yaml (5)

14-14: LGTM: Build number increment is appropriate.

The build number increment is correct as we're modifying dependencies without changing the package version.


30-31: LGTM: Addition of setuptools as host requirement.

The addition of setuptools is appropriate and aligns with the PR objectives. This is a common requirement for Python packages using setup.py for their build process.


41-41: LGTM: Reasonable HMMER version constraint update.

The update from HMMER <=3.3.2 to <=3.4 is a conservative change that allows using the latest stable release while maintaining backward compatibility.


Line range hint 14-41: Consider comprehensive testing with updated dependencies.

While the dependency updates look reasonable, it would be beneficial to verify that macsyfinder works correctly with:

  1. The latest pandas 2.x version (2.2.3)
  2. The latest HMMER 3.4
  3. Different Python versions (>=3.10)

This will ensure the package remains stable with the relaxed version constraints.


38-38: Verify compatibility with pandas 2.x series.

The update from pandas <=1.5.1 to <=2.2.3 is a major version jump. While relaxing version constraints is good for flexibility, pandas 2.x introduced breaking changes that might affect macsyfinder.

Let's check if there are any known compatibility issues:

✅ Verification successful

Let me gather more specific information about how macsyfinder uses pandas by searching in its source code.


Based on the search results, I can now generate the final response since we have enough information to make a determination.

Pandas version constraint update appears safe to proceed

The search results show that pandas is not directly used in the macsyfinder package itself, as all the pandas imports found are from other recipe packages (phabox, scanpy-scripts, poretools, concoct, and behst). The pandas dependency in the meta.yaml is likely a build or runtime dependency without direct usage of pandas-specific features that could be affected by breaking changes.

Since:

  • No direct pandas usage was found in macsyfinder's source code
  • The package maintains the same lower bound (>=1.1.5)
  • The update only increases the upper bound to allow newer versions
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if macsyfinder's source code has any pandas-specific code that might be affected
rg -l 'pandas' | xargs rg -A 5 'pd\.|DataFrame|Series'

# Check if there are any existing issues or discussions about pandas 2.x compatibility
gh issue list -R gem-pasteur/macsyfinder --search "pandas 2"

Length of output: 882


Script:

#!/bin/bash
# Search for pandas imports and usage in macsyfinder's source code
rg -A 5 "import pandas|from pandas" 

# Search for DataFrame creation or manipulation
rg -A 5 "DataFrame\(|\.to_csv|\.read_csv"

# Look for any test files that might use pandas
fd "test.*\.py" --exec rg -l "pandas|DataFrame|Series" {}

Length of output: 2082


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@martin-g martin-g merged commit 05f6c3f into bioconda:master Oct 23, 2024
7 checks passed
@bneron bneron deleted the macsyfinder branch January 6, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants