Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resistify #51675

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Update Resistify #51675

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e52ef4
Update meta.yaml
SwiftSeal Oct 25, 2024
ff00ebd
Update meta.yaml
SwiftSeal Oct 25, 2024
6823b9b
fix pyproject reqs
SwiftSeal Oct 26, 2024
d717879
move cython
SwiftSeal Oct 26, 2024
83a1a10
Merge branch 'master' into patch-3
aliciaaevans Oct 28, 2024
28b7621
Merge branch 'master' into patch-3
mencian Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions recipes/resistify/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{% set name = "resistify" %}
{% set version = "0.4.0" %}
{% set version = "0.5.0" %}
{% set sha256 = "c23493ec622733fac905afa4c64b6ca3ce79afe44cf358433b0b81f115578e96" %}

package:
name: "{{ name }}"
version: "{{ version }}"

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: ba06333873fcb1e07820cb0895755b42a615d289437749846e280bc87d6abf2c
url: https://github.com/SwiftSeal/resistify/archive/refs/tags/v{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
noarch: python
Expand All @@ -21,16 +22,22 @@ build:
requirements:
host:
- pip
- python >=3.9
- python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Consider maintaining Python version constraint.

Removing the Python >=3.9 constraint might lead to compatibility issues, especially with the ML frameworks added as dependencies. Consider keeping version constraints to ensure compatibility.

-    python
+    python >=3.9

Also applies to: 28-28

- hatchling
run:
- python >=3.9
- scikit-learn ==0.24.2
- python
- scikit-learn==0.24.2
- biopython
- numpy
- rich
- rich-argparse
- hmmer
- pytorch
- torchvision
- torchaudio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix trailing whitespace.

Remove trailing spaces from the following lines:

  • Line 37: pytorch
  • Line 38: torchvision
  • Line 59: Empty line with spaces

Also applies to: 59-59

🧰 Tools
🪛 yamllint

[error] 37-37: trailing spaces

(trailing-spaces)

[error] 38-38: trailing spaces

(trailing-spaces)

- cpuonly
- fair-esm
- transformers==4.31.0
- sentencepiece

test:
imports:
Expand All @@ -40,5 +47,12 @@ test:

about:
home: https://github.com/swiftseal/resistify
doc_url: "https://github.com/SwiftSeal/resistify/blob/main/README.md"
license: MIT
license_file: LICENSE
summary: A resistance gene annotation tool
description: |
Resistify is a nucleotide-binding leucine rich repeat (NLR) annotation
program, for the purpose of identifying putative disease resistance
genes in plant genomes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix trailing whitespace.

Remove the trailing whitespace on line 59.

-  
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
🧰 Tools
🪛 yamllint

[error] 59-59: trailing spaces

(trailing-spaces)

Loading