Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package doubletdetection #51786

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add package doubletdetection #51786

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6034c8
Added meta.yaml
LeonHafner Oct 29, 2024
3483864
clean up recipe
mencian Oct 29, 2024
e199ec8
Merge branch 'master' into doubletdetection
mencian Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions recipes/doubletdetection/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{% set name = "doubletdetection" %}
{% set version = "4.2" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/doubletdetection-{{ version }}.tar.gz
sha256: 77273d543a7c9b4f4e795b7b664c28bce0613b3a3a7c7f5137974012400a0a6c

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0

requirements:
host:
- python >=3.6,<4.0
- poetry >=1.0
- setuptools
- poetry-core
- pip
run:
Comment on lines +20 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Align Python version constraints between host and run sections.

The Python version requirements are inconsistent:

  • host: python >=3.6,<4.0
  • run: python >=3.6.1,<4.0

This could potentially cause build issues.

  host:
-   - python >=3.6,<4.0
+   - python >=3.6.1,<4.0
    - poetry >=1.0

Also applies to: 25-36

- python >=3.6.1,<4.0
- anndata >=0.6
- ipywidgets
- leidenalg
- louvain
- matplotlib-base >=3.1
- numpy >=1.14.2
- pandas >=0.22.0
- phenograph
- scanpy >1.4.4
- scipy >=1.0.1
- tqdm
run_constrained:
- black >=20.8b1
- flake8 >=3.7.7
- furo *
- myst-parser *
- nbsphinx *
- nbsphinx-link *
- pre-commit >=2.7.1
- pytest >=4.4
- sphinx >=4.1,<4.4
- sphinx-autodoc-typehints *
Comment on lines +39 to +49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider moving development dependencies to optional features.

The run_constrained section includes development tools that aren't required for normal package operation. Consider making these optional to reduce the dependency footprint.

You could move these to optional features using outputs section or create a separate -dev package. Would you like me to provide an example implementation?


test:
imports:
- doubletdetection
commands:
- pip check
requires:
- pip

about:
home: https://github.com/JonathanShor/DoubletDetection
summary: Method to detect and enable removal of doublets from single-cell RNA-sequencing.
license: MIT
license_file: LICENSE.txt

extra:
recipe-maintainers:
- LeonHafner