Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yacht to 1.3.0 #51918

Closed
wants to merge 15 commits into from
Closed

Update yacht to 1.3.0 #51918

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
39b1a83
Update yacht to 1.3.0
BiocondaBot Nov 4, 2024
5445276
edit python pinning
mencian Nov 4, 2024
a75fc13
Update meta.yaml
mencian Nov 4, 2024
036a152
Update meta.yaml
mencian Nov 4, 2024
38f5085
Update yacht to 1.3.0
BiocondaBot Nov 4, 2024
4d832db
Update meta.yaml
mencian Nov 4, 2024
0de5724
edit meta.yaml
mencian Nov 4, 2024
51c1eb9
Update meta.yaml
mencian Nov 4, 2024
914496b
add cxx compiler
mencian Nov 4, 2024
f304be6
Update yacht to 1.3.0
BiocondaBot Nov 5, 2024
135084b
Update yacht to 1.3.0
BiocondaBot Nov 5, 2024
30c3fe6
Update yacht to 1.3.0
BiocondaBot Nov 5, 2024
244d6b5
add zlib
mencian Nov 5, 2024
ba72930
Update yacht to 1.3.0
BiocondaBot Nov 6, 2024
c38f41a
Update yacht to 1.3.0
BiocondaBot Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 11 additions & 22 deletions recipes/yacht/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
{% set version = "1.2.3" %}
{% set version = "1.3.0" %}

package:
name: yacht
version: {{ version }}

source:
url: https://github.com/KoslickiLab/YACHT/releases/download/v{{ version }}/yacht-{{ version }}.tar.gz
sha256: 93adb23ad4f143d48c9f0ea661fe2283ff42e9c51e073a05460596ecabc65214
sha256: 68d272daeb70ed7390aa2d468934dc4bf0aa9a021f99fe99847b8a664e8ac8cf

build:
number: 0
noarch: python
skip: True # [win or osx]
skip: True # [py < 37 or py > 311]
script: "{{ PYTHON }} -m pip install . --no-deps --no-build-isolation --no-cache-dir -vvv"
run_exports:
- {{ pin_subpackage('yacht', max_pin="x") }}

requirements:
build:
- {{ compiler('cxx') }}
- {{ compiler('c') }}
- make
host:
- python >3.6
- python
- pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix inconsistent Python version constraints.

The host requirement python lacks version constraints, which is inconsistent with the build skip conditions (py < 37 or py > 311). This could lead to installation issues.

Apply this change to align with build constraints:

-    - python
+    - python >=3.7,<3.12
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- python
- python >=3.7,<3.12

- pandas
- pytaxonkit
Expand All @@ -30,10 +33,10 @@ requirements:
- numpy
- setuptools
- requests
- zlib
run:
- python >3.6
- sourmash >=4.8.3,<5
- rust
- python
- sourmash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix inconsistent Python version constraints in run requirements.

Similar to host requirements, the run requirement for Python should be constrained to match build skip conditions.

Apply this change:

-    - python
+    - python >=3.7,<3.12
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- python
- python >=3.7,<3.12

- scipy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Restore version constraints for sourmash dependency.

Removing version constraints from sourmash could lead to compatibility issues. Consider maintaining version constraints to ensure compatibility.

Apply this change:

-    - sourmash
+    - sourmash >=4.8.3,<5
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- sourmash
- sourmash >=4.8.3,<5

- requests
- numpy
Expand All @@ -51,7 +54,6 @@ requirements:
- ruff
- sourmash_plugin_branchwater


test:
commands:
- yacht --help
Expand All @@ -66,20 +68,7 @@ about:
doc_url: https://github.com/KoslickiLab/YACHT/wiki

extra:
skip-lints:
- should_not_be_noarch_skip
- should_use_compilers
identifiers:
- doi:10.1101/2023.04.18.537298
recipe-maintainers:
- dkoslicki
authors:
- dkoslicki
- chunyuma
- sew347
- mlupei
- mfl15
- ShaopengLiu1
- raquellewei
- mohsenht

Loading