Add osx-arm64 to r-facets #52091
Add osx-arm64 to r-facets #52091
Conversation
📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/bioconductor-rsamtools/meta.yaml(2 hunks)
🔇 Additional comments (2)
recipes/bioconductor-rsamtools/meta.yaml (2)
69-69: LGTM: Platform addition follows convention
The addition of osx-arm64 to additional-platforms is properly formatted and aligns with the PR objective.
Line range hint 52-54: Verify compiler settings for osx-arm64
Please ensure that the compiler settings and libcxx condition are compatible with osx-arm64 architecture.
#!/bin/bash
# Description: Check for arm64-specific compiler settings in similar recipes
# Search for other recipes with osx-arm64 support and compiler settings
rg -B 5 -A 5 "osx-arm64" recipes/ | rg -B 5 -A 5 "compiler\('c'\)|compiler\('cxx'\)"
# Look for libcxx usage patterns
rg "libcxx.*\[osx\]" recipes/| @@ -13,7 +13,7 @@ source: | |||
| - 'https://depot.galaxyproject.org/software/bioconductor-{{ name|lower }}/bioconductor-{{ name|lower }}_{{ version }}_src_all.tar.gz' | |||
| md5: 63af2a7dd2513e992fd78b26ca2b3775 | |||
| build: | |||
| number: 2 | |||
| number: 3 | |||
There was a problem hiding this comment.
💡 Codebase verification
Standardize libcxx versions across all recipes for [osx]
Multiple recipes have inconsistent libcxx version specifications for macOS. Please ensure all [osx] dependencies use a compatible libcxx version aligned with Bioconductor 3.18.
🔗 Analysis chain
Verify dependency versions for Bioconductor 3.18
The version bump to 2.18.0 and Bioconductor 3.18 is significant. Let's verify that all dependencies are properly aligned with this version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if dependencies are aligned with Bioconductor 3.18
# Look for other recipes that might need updating
# Search for related Bioconductor package versions
rg -l "bioc = \"3.18\"" recipes/
Length of output: 1400
…essive dependencies to build for osx-arm64
|
@martin-g can you review? |
The r-facets package compiles locally on osx-arm64 - committing this to CI now to test.
[was also r-spp, but this failed CI]