Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MashMap v3.1.3 build. #52373

Merged
merged 19 commits into from
Dec 4, 2024
Merged

Fix MashMap v3.1.3 build. #52373

merged 19 commits into from
Dec 4, 2024

Conversation

bkille
Copy link
Contributor

@bkille bkille commented Nov 25, 2024

The most recent build of MashMap v3.1.3 (PR #51161) is broken due to it being linked against BLIS instead of BLAS (issue #52321). It also appears that the GSL shared library is also missing according to the output in #52321, even though it is present in the recipe as a host and run dependency.

I don't know what caused this, but I'm going to rebuild and see if I run into the same issue.

Fixes #52321.

@bkille
Copy link
Contributor Author

bkille commented Dec 2, 2024

@mencian thanks for improving the meta.yaml and helping out with the OSX build. It seems that even though the OSX SDK is specified as 10.15 (or even 11.0), the CI container always downloads the 10.13 version:

Downloading 10.13 sdk
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 25.2M  100 25.2M    0     0  [36](https://github.com/bioconda/bioconda-recipes/actions/runs/12062066964/job/33635392250?pr=52373#step:7:37).3M      0 --:--:-- --:--:-- --:--:-- 36.3M
MacOSX10.13.sdk.tar.xz: OK
Found CONDA_BUILD_SYSROOT: /Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk

Is there another way to specify which OSX SDK to use? Thanks again for your help!

@martin-g
Copy link
Contributor

martin-g commented Dec 3, 2024

See

MACOSX_DEPLOYMENT_TARGET: # [osx and x86_64]
- "10.15" # [osx and x86_64]
MACOSX_SDK_VERSION: # [osx and x86_64]
- "10.15" # [osx and x86_64]
for example

@mencian
Copy link
Contributor

mencian commented Dec 3, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 mashmap-3.1.3-pl5321hb4818e0_2.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 mashmap-3.1.3-pl5321h66756e5_2.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-arm64 mashmap-3.1.3-pl5321h12b9755_2.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/9adb0e68-62aa-4375-9670-0d96e01012e4/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 mashmap-3.1.3-pl5321hdf7b3cb_2.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/974bcd8e-adee-4b9f-8410-2a26ac1fc9ac/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
mashmap 3.1.3--pl5321hb4818e0_2 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/mashmap---3.1.3--pl5321hb4818e0_2.tar.gz | docker load

@mencian
Copy link
Contributor

mencian commented Dec 3, 2024

@bkille I've bumped the OSX SDK to 10.15 and that seems to have done the trick. Please take a look at the built artifacts to see if BLAS is correctly linked.

@mencian mencian assigned bkille and unassigned bkille Dec 3, 2024
@mencian mencian added the please review & merge set to ask for merge label Dec 4, 2024
@mencian mencian merged commit 31cae24 into bioconda:master Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MashMap 3.1.3 broken
4 participants