Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pycoverm #52941

Merged
merged 10 commits into from
Dec 21, 2024
Merged

Add pycoverm #52941

merged 10 commits into from
Dec 21, 2024

Conversation

apcamargo
Copy link
Contributor

This PR adds the pycoverm Python library.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@apcamargo
Copy link
Contributor Author

apcamargo commented Dec 20, 2024

@prototaxites @mbhall88 I ended up creating a separate PR to include a test.

@mbhall88 should we add # [build_platform != target_platform] to the additional build requirements?

@apcamargo
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Dec 20, 2024
@apcamargo
Copy link
Contributor Author

apcamargo commented Dec 20, 2024

@jakobnissen Not sure if this still helps you in any way, but this is finally in a working recipe.

@mbhall88
Copy link
Contributor

Actually did you want to add @apcamargo and/or @prototaxites to the recipe maintainers?

@apcamargo
Copy link
Contributor Author

I can be the maintainer. No problem.

Should we put # [build_platform != target_platform] in any other build requirement? I'm not familiar with this selector(?)

recipes/pycoverm/meta.yaml Outdated Show resolved Hide resolved
@daler
Copy link
Member

daler commented Dec 21, 2024

FYI in general our policy is just simple existence checks (bioconda docs), but the bam seems small enough so this should be fine.

@daler daler merged commit a442e72 into bioconda:master Dec 21, 2024
5 checks passed
@AroneyS AroneyS mentioned this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants