Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch srst2 versions 0.1.6 and 0.2.0 #6957

Merged
merged 15 commits into from
Dec 15, 2017
Merged

Conversation

Takadonet
Copy link
Contributor

@Takadonet Takadonet commented Nov 29, 2017

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@mbargull
Copy link
Member

mbargull commented Dec 6, 2017

Do the changes from the patch alter the program's behavior for use cases which are not affected by katholt/srst2#99? If they do alter the program's default behavior, I don't think we should add those changes here but rather wait for an upstream update.

As for the failed tests: Those are due to a current limitation in the testing framework concerning the use of single quotes in the test commands. If you replace the single quotes with double quotes, it should work fine.

@Takadonet
Copy link
Contributor Author

Fixed failed tests for version 0.1.4.6 .

They don't alter the end results but just address the issue where file path cannot have '.' character. I am for sure willing to remove them from this branch for the latest version of the tool. It will limit our ability to update our wrapper since we don't have control on when the author will accept and publish a new release.

@Takadonet
Copy link
Contributor Author

@mbargull Removed patch and hope for srst2 to be updated with bug fix.

@mbargull
Copy link
Member

Do you want to reinstate the patch for the current version or should we merge without it? After having a closer look at the patch, I think it is a justifiable addition/fix.

@Takadonet
Copy link
Contributor Author

I will reinstate the patch tomorrow. Working from home with a sick kid at the moment.

@mbargull
Copy link
Member

mbargull commented Dec 14, 2017

No worries, I pushed the necessary changes. Everyone get well soon!

@mbargull
Copy link
Member

@ericenns: In #3767 you added the recipe for srst2 0.1.4.6. But the software's actual version seems to be 0.1.6. Was that just a typo?

@ericenns
Copy link
Contributor

@mbargull yes that is a typo. I believe I introduced it when we were updating our srst2 galaxy tool to use conda and I used the version we had in there which was a typo.

@ericenns
Copy link
Contributor

@mbargull I guess I should clarify the typo is the 0.1.4.6 which should have been 0.1.6

@mbargull
Copy link
Member

Thanks for clarification, @ericenns. I just added a commit to this PR to fix this.

@mbargull mbargull changed the title [WIP] Patch srst2 0.1.4.6 version Patch srst2 versions 0.1.6 and 0.2.0 Dec 15, 2017
@ericenns ericenns merged commit 432a277 into bioconda:master Dec 15, 2017
@ericenns ericenns deleted the patch_srst2 branch October 3, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants