Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding "vals" to GithubRelease changes for API and expanded assets #912

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

holtjma
Copy link
Contributor

@holtjma holtjma commented Aug 24, 2023

With #907, we resolved an issue where GitHub release files were not being detected via autobump. Recent logs (e.g. https://circleci.com/api/v1.1/project/github/bioconda/bioconda-utils/44398/output/110/0?file=true&allocation-id=64e7a915cc25c03a3d0cf725-0-build%2FABCDEFGH) show this has changed and it is correctly detecting the version update. However, we are generating new errors now that are specifically caused by the PR submission (this was not previously tested, an oversight on my part):

19:09:44 �[32mBIOCONDA INFO�[0m Recipe hiphase: updating from remote bump/hiphase�[0m
19:09:46 �[31mBIOCONDA ERROR�[0m While processing hiphase
Traceback (most recent call last):
  File "/opt/mambaforge/envs/bioconda/lib/python3.8/site-packages/bioconda_utils/aiopipe.py", line 199, in process
    await filt.apply(item)
  File "/opt/mambaforge/envs/bioconda/lib/python3.8/site-packages/bioconda_utils/autobump.py", line 1142, in apply
    author = self.get_github_author(recipe)
  File "/opt/mambaforge/envs/bioconda/lib/python3.8/site-packages/bioconda_utils/autobump.py", line 1135, in get_github_author
    return ver['vals']['account']
KeyError: 'vals'�[0m

This is caused by a lack of passing the vals fields through from the previous PR. Error was replicated locally via:

bioconda-utils autobump recipes/ config.yml --package hiphase --create-pr --dry-run

With the very minor changes here, vals is passed through and we now get a full run without errors via dry-run:

13:35:00 BIOCONDA INFO Updating checksum for hiphase 0.10.2                                                                                                                                            
13:35:00 BIOCONDA INFO Checking out branch bump/hiphase                                                                                                                                                
13:35:06 BIOCONDA INFO Would create PR 'Update hiphase to 0.10.2'                                                                                                                                      
13:35:06 BIOCONDA INFO  title: Update hiphase to 0.10.2                                                                                                                                                
13:35:06 BIOCONDA INFO  body:                                                                                                                                                                          
<!--
creator: autobump
type: bump_version
recipe: hiphase
orig_version: 0.10.0
orig_build_number: 0
new_version: 0.10.2
new_build_bumber: 0
-->

Update [`hiphase`](https://bioconda.github.io/recipes/hiphase/README.html): **0.10.0** &rarr; **0.10.2**

[![install with bioconda](https://img.shields.io/badge/install%20with-bioconda-brightgreen.svg?style=flat)](http://bioconda.github.io/recipes/hiphase/README.html) [![Conda](https://img.shields.io/conda/dn/bioconda/hiphase.svg)](https://anaconda.org/bioconda/hiphase/files)

Info | Link or Description
-----|--------------------
Recipe | [`recipes/hiphase`](https://github.com//bioconda/bioconda-recipes/tree/bump/hiphase/recipes/hiphase) (click to view/edit other files)
Summary | Small and structural variant phasing tool for PacBio HiFi reads
Home | [https://github.com/PacificBiosciences/HiPhase](https://github.com/PacificBiosciences/HiPhase)
Releases |[]()
Recipe Maintainer(s) | @holtjma, @ctsa
Author | `@PacificBiosciences`
***


This pull request was automatically generated (see [docs](https://bioconda.github.io/contributor/updating.html)).

13:35:06 BIOCONDA INFO Would modify PR -1                                                                                                                                                              
13:35:06 BIOCONDA INFO New labels: ['autobump', 'new version']                                                                                                                                         
13:35:06 BIOCONDA INFO Created PR -1: Update hiphase to 0.10.2                                                                                                                                         
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:11<00:00, 11.63s/it]
13:35:06 BIOCONDA WARNING Finished update
13:35:06 BIOCONDA INFO Unrecognized URL stats:
13:35:06 BIOCONDA INFO 
13:35:06 BIOCONDA INFO Recipe status statistics:
13:35:06 BIOCONDA INFO Updated: 1
13:35:06 BIOCONDA INFO SUM: 1
13:35:06 BIOCONDA WARNING Switching back to master

Hopefully, this is the last PR related to this issue!

@johanneskoester johanneskoester merged commit 9e0e445 into bioconda:master Aug 25, 2023
11 checks passed
@johanneskoester
Copy link
Contributor

Thank you so much! This is greatly appreciated!

@holtjma holtjma deleted the fix_missing_vals branch August 25, 2023 12:49
johanneskoester pushed a commit that referenced this pull request Oct 4, 2023
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.5.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.4.0...v2.5.0)
(2023-10-04)


### Features

* add special lints for bioconda-repodata-patches recipe
([#855](https://www.github.com/bioconda/bioconda-utils/issues/855))
([11c9229](https://www.github.com/bioconda/bioconda-utils/commit/11c92296bbc566fcd481ea45c4d55247b4ba154d))


### Bug Fixes

* adding "vals" to GithubRelease changes for API and expanded assets
([#912](https://www.github.com/bioconda/bioconda-utils/issues/912))
([9e0e445](https://www.github.com/bioconda/bioconda-utils/commit/9e0e44581cade8d994a5b923964df060122b7519))
* Remove htslib build pinning
([#917](https://www.github.com/bioconda/bioconda-utils/issues/917))
([c7efb92](https://www.github.com/bioconda/bioconda-utils/commit/c7efb9250312abdcfbdc10be60b5a0fa92e52726))
* Version constraints can start with `!` as well
([#919](https://www.github.com/bioconda/bioconda-utils/issues/919))
([ee56f6e](https://www.github.com/bioconda/bioconda-utils/commit/ee56f6e1d20aa7c96f150ff79a084faf0521e70b)),
closes [#918](https://www.github.com/bioconda/bioconda-utils/issues/918)


### Documentation

* try to clarify some confusion with run_exports.
([#914](https://www.github.com/bioconda/bioconda-utils/issues/914))
([417e7da](https://www.github.com/bioconda/bioconda-utils/commit/417e7da6524c71ac0aafdcd75244bd001de17efd))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants