Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix version number check in repodata_patches_no_version_bump() #946

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jmarshall
Copy link
Member

PR #855 was merged without review or, apparently, any testing 😄

@jmarshall jmarshall changed the title Fix version number check in repodata_patches_no_version_bump() fix: Fix version number check in repodata_patches_no_version_bump() Dec 12, 2023
Copy link
Contributor

@aliciaaevans aliciaaevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

Copy link
Contributor

@aliciaaevans aliciaaevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually per the docs, at least one commit message needs to have the fix: prefix.

@jmarshall
Copy link
Member Author

@aliciaaevans: I have adjusted the commit message. Until the linter enforces conventional commit formatting on the right piece of text, IMHO it would be reasonable for maintainers to simply make commit message adjustments themselves when merging.

@aliciaaevans aliciaaevans merged commit 73e69b2 into bioconda:master Dec 13, 2023
9 checks passed
@jmarshall jmarshall deleted the linter-bug branch December 13, 2023 22:46
aliciaaevans pushed a commit that referenced this pull request Dec 13, 2023
🤖 I have created a release \*beep\* \*boop\*
---
###
[2.11.1](https://www.github.com/bioconda/bioconda-utils/compare/v2.11.0...v2.11.1)
(2023-12-13)


### Bug Fixes

* add local channel for docker builds
([#945](https://www.github.com/bioconda/bioconda-utils/issues/945))
([de8ce00](https://www.github.com/bioconda/bioconda-utils/commit/de8ce00d1ccf6a395ff6adce97f71b5c6059500f))
* Fix version number check in repodata_patches_no_version_bump()
([#946](https://www.github.com/bioconda/bioconda-utils/issues/946))
([73e69b2](https://www.github.com/bioconda/bioconda-utils/commit/73e69b2f9aabb06f693518b8ee195c7fa897bc76))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants