fix problematic annotation order in handle_error()

biojppm · Aug 12, 2024 · 7aba1e1 · 7aba1e1
1 parent 80196c0
commit 7aba1e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog/current.md b/changelog/current.md
@@ -1,7 +1,7 @@
 
 - Amalgamate: fix include of `<charconv>` (see [rapidyaml#445](https://github.com/biojppm/biojppm/pull/445)).
 - Add `C4_MINGW` ([PR#139](https://github.com/biojppm/c4core/pull/139))
-- Annotate `c4::handle_error()` with `[[noreturn]]` ([PR#137](https://github.com/biojppm/c4core/pull/137))
+- Annotate `c4::handle_error()` with `[[noreturn]]` ([PR#137](https://github.com/biojppm/c4core/pull/137)).
 - Add `bool from_chars(csubstr s, fmt::overflow_checked_<T> *wrapper)`. There was already a function receiving `&wrapper`, but `*wrapper` was missing for use with generic code.
 - Ensure `posix_memalign()` is never called with bad alignment values ([PR#138](https://github.com/biojppm/c4core/pull/138))
 - Update fast_float to v6.1.1 ([PR#136](https://github.com/biojppm/c4core/pull/136))

diff --git a/src/c4/error.hpp b/src/c4/error.hpp
@@ -177,7 +177,8 @@ struct ScopedErrorSettings
 /** source location */
 struct srcloc;
 
-C4CORE_EXPORT [[noreturn]] void handle_error(srcloc s, const char *fmt, ...);
+// watchout: for VS the [[noreturn]] needs to come before other annotations like C4CORE_EXPORT
+[[noreturn]] C4CORE_EXPORT void handle_error(srcloc s, const char *fmt, ...);
 C4CORE_EXPORT void handle_warning(srcloc s, const char *fmt, ...);