fix CI: ubuntu 18.04 cannot run actions/checkout, requires impossible…

… version of nodejs
biojppm · Jul 5, 2024 · aa7cf86 · aa7cf86
1 parent dde49da
commit aa7cf86
Show file tree

Hide file tree

Showing 5 changed files with 125 additions and 94 deletions.
diff --git a/.github/workflows/clang.yml b/.github/workflows/clang.yml
@@ -32,18 +32,18 @@ jobs:
     continue-on-error: true
     if: always()  # https://stackoverflow.com/questions/62045967/github-actions-is-there-a-way-to-continue-on-error-while-still-getting-correct
     runs-on: ubuntu-latest
-    container: ghcr.io/biojppm/c4core/ubuntu18.04:latest  # use the docker image
+    container: ghcr.io/biojppm/c4core/ubuntu22.04:latest  # use the docker image
     strategy:
       fail-fast: false
       matrix:
         include:
-          - {std: 20, cxx: clang++-10 , bt: Debug  , bitlinks: shared64 static32}
-          - {std: 20, cxx: clang++-10 , bt: Release, bitlinks: shared64 static32}
-          - {std: 11, cxx: clang++-6.0, bt: Debug  , bitlinks: shared64 static32}
-          - {std: 11, cxx: clang++-6.0, bt: Release, bitlinks: shared64 static32}
+          - {std: 20, cxx: clang++-17 , bt: Debug  , bitlinks: shared64 static32}
+          - {std: 20, cxx: clang++-17 , bt: Release, bitlinks: shared64 static32}
+          - {std: 11, cxx: clang++-9, bt: Debug  , bitlinks: shared64 static32}
+          - {std: 11, cxx: clang++-9, bt: Release, bitlinks: shared64 static32}
     env: {STD: "${{matrix.std}}", CXX_: "${{matrix.cxx}}", BT: "${{matrix.bt}}", BITLINKS: "${{matrix.bitlinks}}", VG: "${{matrix.vg}}", SAN: "${{matrix.san}}", LINT: "${{matrix.lint}}", OS: "${{matrix.os}}"}
     steps:
-      - {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+      - {name: checkout, uses: actions/checkout@v4, with: {submodules: recursive}}
       - run: git config --system --add safe.directory '*'  # needed for running in the docker image. see https://github.com/actions/checkout/issues/1169
       - run: c4core-install ${{matrix.cxx}}
       - {name: show info, run: source .github/setenv.sh && c4_show_info}
@@ -74,18 +74,18 @@ jobs:
     continue-on-error: true
     if: always()  # https://stackoverflow.com/questions/62045967/github-actions-is-there-a-way-to-continue-on-error-while-still-getting-correct
     runs-on: ubuntu-latest
-    container: ghcr.io/biojppm/c4core/ubuntu18.04:latest  # use the docker image
+    container: ghcr.io/biojppm/c4core/ubuntu22.04:latest  # use the docker image
     strategy:
       fail-fast: false
       matrix:
         include:
-          - {std: 20, cxx: clang++-10 , bt: Debug  , bitlinks: shared64 static32}
-          - {std: 20, cxx: clang++-10 , bt: Release, bitlinks: shared64 static32}
-          - {std: 11, cxx: clang++-6.0, bt: Debug  , bitlinks: shared64 static32}
-          - {std: 11, cxx: clang++-6.0, bt: Release, bitlinks: shared64 static32}
+          - {std: 20, cxx: clang++-17 , bt: Debug  , bitlinks: shared64 static32}
+          - {std: 20, cxx: clang++-17 , bt: Release, bitlinks: shared64 static32}
+          - {std: 11, cxx: clang++-9  , bt: Debug  , bitlinks: shared64 static32}
+          - {std: 11, cxx: clang++-9  , bt: Release, bitlinks: shared64 static32}
     env: {CXXFLAGS: "-fno-exceptions -fno-rtti", STD: "${{matrix.std}}", CXX_: "${{matrix.cxx}}", BT: "${{matrix.bt}}", BITLINKS: "${{matrix.bitlinks}}", VG: "${{matrix.vg}}", SAN: "${{matrix.san}}", LINT: "${{matrix.lint}}", OS: "${{matrix.os}}"}
     steps:
-      - {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+      - {name: checkout, uses: actions/checkout@v4, with: {submodules: recursive}}
       - run: git config --system --add safe.directory '*'  # needed for running in the docker image. see https://github.com/actions/checkout/issues/1169
       - run: c4core-install ${{matrix.cxx}}
       - {name: show info, run: source .github/setenv.sh && c4_show_info}
@@ -121,8 +121,10 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - {std: 11, cxx: clang++-16 , bt: Debug  , vg: on, img: ubuntu18.04}
-          - {std: 11, cxx: clang++-16 , bt: Release, vg: on, img: ubuntu18.04}
+          - {std: 11, cxx: clang++-17 , bt: Debug  , vg: on, img: ubuntu22.04}
+          - {std: 11, cxx: clang++-17 , bt: Release, vg: on, img: ubuntu22.04}
+          - {std: 11, cxx: clang++-16 , bt: Debug  , vg: on, img: ubuntu22.04}
+          - {std: 11, cxx: clang++-16 , bt: Release, vg: on, img: ubuntu22.04}
           - {std: 11, cxx: clang++-15 , bt: Debug  , vg: on, img: ubuntu22.04} # install of clang15 fails on ubuntu18.04
           - {std: 11, cxx: clang++-15 , bt: Release, vg: on, img: ubuntu22.04} # install of clang15 fails on ubuntu18.04
           - {std: 11, cxx: clang++-14 , bt: Debug  , vg: on, img: ubuntu22.04} # install of clang14 fails on ubuntu18.04
@@ -151,7 +153,12 @@ jobs:
           - {std: 11, cxx: clang++-3.9, bt: Release, vg: on, img: ubuntu18.04}
     env: {STD: "${{matrix.std}}", CXX_: "${{matrix.cxx}}", BT: "${{matrix.bt}}", BITLINKS: "${{matrix.bitlinks}}", VG: "${{matrix.vg}}", SAN: "${{matrix.san}}", LINT: "${{matrix.lint}}", OS: "${{matrix.os}}"}
     steps:
-      - {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+      # cannot use the checkout@v3 or v4 action on ubuntu18.04 because of nodejs version
+      #- {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+      #... so we checkout manually:
+      - name: checkout
+        run: |
+          git clone --recursive https://github.com/biojppm/c4core .
       - run: git config --system --add safe.directory '*'  # needed for running in the docker image. see https://github.com/actions/checkout/issues/1169
       - run: c4core-install ${{matrix.cxx}}
       - {name: show info, run: source .github/setenv.sh && c4_show_info}
@@ -182,30 +189,30 @@ jobs:
     continue-on-error: true
     if: always()  # https://stackoverflow.com/questions/62045967/github-actions-is-there-a-way-to-continue-on-error-while-still-getting-correct
     runs-on: ubuntu-latest
-    container: ghcr.io/biojppm/c4core/ubuntu18.04:latest  # use the docker image
+    container: ghcr.io/biojppm/c4core/ubuntu22.04:latest  # use the docker image
     strategy:
       fail-fast: false
       matrix:
         include:
-          - {std: 11, cxx: clang++-16 , bt: asan, bitlinks: static64}
-          - {std: 14, cxx: clang++-16 , bt: asan, bitlinks: static64}
-          - {std: 17, cxx: clang++-16 , bt: asan, bitlinks: static64}
-          - {std: 20, cxx: clang++-16 , bt: asan, bitlinks: static64}
-          - {std: 11, cxx: clang++-16 , bt: lsan, bitlinks: static64}
-          - {std: 14, cxx: clang++-16 , bt: lsan, bitlinks: static64}
-          - {std: 17, cxx: clang++-16 , bt: lsan, bitlinks: static64}
-          - {std: 20, cxx: clang++-16 , bt: lsan, bitlinks: static64}
-          - {std: 11, cxx: clang++-16 , bt: tsan, bitlinks: static64}
-          - {std: 14, cxx: clang++-16 , bt: tsan, bitlinks: static64}
-          - {std: 17, cxx: clang++-16 , bt: tsan, bitlinks: static64}
-          - {std: 20, cxx: clang++-16 , bt: tsan, bitlinks: static64}
-          - {std: 11, cxx: clang++-16 , bt: ubsan, bitlinks: static64}
-          - {std: 14, cxx: clang++-16 , bt: ubsan, bitlinks: static64}
-          - {std: 17, cxx: clang++-16 , bt: ubsan, bitlinks: static64}
-          - {std: 20, cxx: clang++-16 , bt: ubsan, bitlinks: static64}
+          - {std: 11, cxx: clang++-17 , bt: asan, bitlinks: static64}
+          - {std: 14, cxx: clang++-17 , bt: asan, bitlinks: static64}
+          - {std: 17, cxx: clang++-17 , bt: asan, bitlinks: static64}
+          - {std: 20, cxx: clang++-17 , bt: asan, bitlinks: static64}
+          - {std: 11, cxx: clang++-17 , bt: lsan, bitlinks: static64}
+          - {std: 14, cxx: clang++-17 , bt: lsan, bitlinks: static64}
+          - {std: 17, cxx: clang++-17 , bt: lsan, bitlinks: static64}
+          - {std: 20, cxx: clang++-17 , bt: lsan, bitlinks: static64}
+          - {std: 11, cxx: clang++-17 , bt: tsan, bitlinks: static64}
+          - {std: 14, cxx: clang++-17 , bt: tsan, bitlinks: static64}
+          - {std: 17, cxx: clang++-17 , bt: tsan, bitlinks: static64}
+          - {std: 20, cxx: clang++-17 , bt: tsan, bitlinks: static64}
+          - {std: 11, cxx: clang++-17 , bt: ubsan, bitlinks: static64}
+          - {std: 14, cxx: clang++-17 , bt: ubsan, bitlinks: static64}
+          - {std: 17, cxx: clang++-17 , bt: ubsan, bitlinks: static64}
+          - {std: 20, cxx: clang++-17 , bt: ubsan, bitlinks: static64}
     env: {STD: "${{matrix.std}}", CXX_: "${{matrix.cxx}}", BT: "${{matrix.bt}}", BITLINKS: "${{matrix.bitlinks}}", VG: "${{matrix.vg}}", SAN: "${{matrix.san}}", LINT: "${{matrix.lint}}", OS: "${{matrix.os}}"}
     steps:
-      - {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+      - {name: checkout, uses: actions/checkout@v4, with: {submodules: recursive}}
       - run: git config --system --add safe.directory '*'  # needed for running in the docker image. see https://github.com/actions/checkout/issues/1169
       - run: c4core-install ${{matrix.cxx}}
       - {name: show info, run: source .github/setenv.sh && c4_show_info}
@@ -251,7 +258,7 @@ jobs:
 #          - {std: 20, cxx: clang++-10, bt: Release, bitlinks: shared64, os: ubuntu-20.04}
 #    env: {STD: "${{matrix.std}}", CXX_: "${{matrix.cxx}}", BT: "${{matrix.bt}}", BITLINKS: "${{matrix.bitlinks}}", VG: "${{matrix.vg}}", SAN: "${{matrix.san}}", LINT: "${{matrix.lint}}", OS: "${{matrix.os}}"}
 #    steps:
-#      - {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+#      - {name: checkout, uses: actions/checkout@v4, with: {submodules: recursive}}
 #      - run: git config --system --add safe.directory '*'  # needed for running in the docker image. see https://github.com/actions/checkout/issues/1169
 #      - {name: install requirements, run: source .github/reqs.sh && c4_install_test_requirements $OS}
 #      - {name: show info, run: source .github/setenv.sh && c4_show_info}

diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml
@@ -32,23 +32,23 @@ jobs:
     continue-on-error: true
     if: always()  # https://stackoverflow.com/questions/62045967/github-actions-is-there-a-way-to-continue-on-error-while-still-getting-correct
     runs-on: ubuntu-latest
-    container: ghcr.io/biojppm/c4core/ubuntu18.04:latest  # use the docker image
+    container: ghcr.io/biojppm/c4core/ubuntu22.04:latest  # use the docker image
     strategy:
       fail-fast: false
       matrix:
         include:
           # clang tidy takes a long time, so don't do multiple bits/linktypes
-          - {std: 11, cxx: clang++-16, bt: Debug             , lint: clang-tidy, bitlinks: shared64}
-          - {std: 11, cxx: clang++-16, bt: Debug             , lint: clang-tidy, bitlinks: shared32}
-          - {std: 11, cxx: clang++-16, bt: Debug             , lint: clang-tidy, bitlinks: static64}
-          - {std: 11, cxx: clang++-16, bt: Debug             , lint: clang-tidy, bitlinks: static32}
-          - {std: 11, cxx: clang++-16, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: shared64}
-          - {std: 11, cxx: clang++-16, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: shared32}
-          - {std: 11, cxx: clang++-16, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: static64}
-          - {std: 11, cxx: clang++-16, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: static32}
+          - {std: 11, cxx: clang++-17, bt: Debug             , lint: clang-tidy, bitlinks: shared64}
+          - {std: 11, cxx: clang++-17, bt: Debug             , lint: clang-tidy, bitlinks: shared32}
+          - {std: 11, cxx: clang++-17, bt: Debug             , lint: clang-tidy, bitlinks: static64}
+          - {std: 11, cxx: clang++-17, bt: Debug             , lint: clang-tidy, bitlinks: static32}
+          - {std: 11, cxx: clang++-17, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: shared64}
+          - {std: 11, cxx: clang++-17, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: shared32}
+          - {std: 11, cxx: clang++-17, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: static64}
+          - {std: 11, cxx: clang++-17, bt: ReleaseWithDebInfo, lint: clang-tidy, bitlinks: static32}
     env: {STD: "${{matrix.std}}", CXX_: "${{matrix.cxx}}", BT: "${{matrix.bt}}", BITLINKS: "${{matrix.bitlinks}}", VG: "${{matrix.vg}}", SAN: "${{matrix.san}}", LINT: "${{matrix.lint}}", OS: "${{matrix.os}}"}
     steps:
-      - {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive}}
+      - {name: checkout, uses: actions/checkout@v4, with: {submodules: recursive}}
       - run: git config --system --add safe.directory '*'  # needed for running in the docker image. see https://github.com/actions/checkout/issues/1169
       - run: c4core-install ${{matrix.cxx}}
       - {name: show info, run: source .github/setenv.sh && c4_show_info}