Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc-4.8.hpp unconditionally uses gcc-specific macro on any platform #125

Closed
yrHeTaTeJlb opened this issue Sep 12, 2023 · 0 comments · Fixed by #133
Closed

gcc-4.8.hpp unconditionally uses gcc-specific macro on any platform #125

yrHeTaTeJlb opened this issue Sep 12, 2023 · 0 comments · Fixed by #133

Comments

@yrHeTaTeJlb
Copy link

yrHeTaTeJlb commented Sep 12, 2023 •
edited
Loading

This line leads to ryml_all.hpp compile errors on VS2019

error C4668: '__GNUC__' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'
@yrHeTaTeJlb yrHeTaTeJlb changed the title gcc-4.8.hpp uses gcc-specific on any platform gcc-4.8.hpp unconditionally uses gcc-specific macro on any platform Sep 12, 2023
biojppm added a commit that referenced this issue Apr 19, 2024
@biojppm
re #125: __GNUC__ may not be defined in polyfill for gcc4.8
df157a0
@biojppm biojppm mentioned this issue Apr 19, 2024
Merged
biojppm added a commit that referenced this issue Apr 19, 2024
@biojppm
re #125: __GNUC__ may not be defined in polyfill for gcc4.8
aaa3d94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor fixes and update docs+changelog biojppm/c4core
1 participant
@yrHeTaTeJlb