Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] add Android support for API 16+ #129

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

mangel9742
Copy link
Contributor

Concerning the issue : #127
memalign was added for Android API since version 16. Adding this permits us to build c4core in android_armv8 and android_x86_64.

@biojppm
Copy link
Owner

biojppm commented Jan 11, 2024

Thanks!

@biojppm biojppm closed this Jan 11, 2024
@biojppm biojppm reopened this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47ba0fa) 96.99% compared to head (4a93948) 96.98%.
Report is 2 commits behind head on master.

❗ Current head 4a93948 differs from pull request most recent head 7618abf. Consider uploading reports for the commit 7618abf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   96.99%   96.98%   -0.01%     
==========================================
  Files          28       28              
  Lines        3129     3119      -10     
==========================================
- Hits         3035     3025      -10     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biojppm
Copy link
Owner

biojppm commented Jan 11, 2024

@mangel9742 I need to update the changelog. Can you either enable the checkbox "Allow edits by maintainers" in your PR page, or (failing that) add this to changelog/current.md?

----------------------------- changelog/current.md -----------------------------
index 0d29ce4..cf759f4 100644
@@ -20,6 +20,7 @@ assert(to_substr(arr).len == 9);
 assert(to_substr((char*)ptr).len == 3); // as before
 ```
 
+
 ### New features
 
 - [#PR101](https://github.com/biojppm/c4core/pulls/101): For `substr` and `csubstr`:
@@ -51,6 +52,7 @@ assert(to_substr((char*)ptr).len == 3); // as before
 
 ### Fixes
 
+- [PR#129](https://github.com/biojppm/c4core/pull/129) - Support android by enabling `aalloc()`'s call to `memalign()`, available for API 16+.
 - [PR#115](https://github.com/biojppm/c4core/pull/115) - Refactor of `c4::blob`/`c4::cblob`. Use SFINAE to invalidate some of the constructors.
 - [PR#110](https://github.com/biojppm/c4core/pull/110)/[PR#107](https://github.com/biojppm/c4core/pull/107) - Update fast_float.
 - [PR#108](https://github.com/biojppm/c4core/pull/108) - Fix preprocessor concatenation of strings in `C4_NOT_IMPLEMENTED_MSG()` and `C4_NOT_IMPLEMENTED_IF_MSG()`.
@@ -62,3 +64,8 @@ assert(to_substr((char*)ptr).len == 3); // as before
 - Inject explicit `#include <charconv>` on the amalgamated header. The amalgamation tool was filtering all prior includes, thus causing a compilation error. Addresses [rapidyaml#364](https://github.com/biojppm/rapidyaml/issues/364).
 - [PR#117](https://github.com/biojppm/c4core/pull/117): Windows: fix compilation with MSVC/clang++.
 - Windows: add missing `C4CORE_EXPORT` to `c4::base64_valid()`, `c4::base64_encode()` and `c4::base64_decode()`.
+
+
+### Thanks
+
+- @mangel9742

@biojppm biojppm merged commit e55d82c into biojppm:master Mar 8, 2024
beicause added a commit to beicause/godot that referenced this pull request Jul 31, 2024
beicause added a commit to beicause/godot that referenced this pull request Jul 31, 2024
beicause added a commit to beicause/godot that referenced this pull request Jul 31, 2024
beicause added a commit to beicause/godot that referenced this pull request Jul 31, 2024
beicause added a commit to beicause/godot that referenced this pull request Jul 31, 2024
beicause added a commit to beicause/godot that referenced this pull request Jul 31, 2024
beicause added a commit to beicause/godot that referenced this pull request Aug 1, 2024
beicause added a commit to beicause/godot that referenced this pull request Aug 6, 2024
beicause added a commit to beicause/godot that referenced this pull request Aug 10, 2024
beicause added a commit to beicause/godot that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants