Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix build with C4CORE_NO_FAST_FLOAT #42

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

mbs-c
Copy link
Contributor

@mbs-c mbs-c commented Oct 20, 2021

Building with that option was previously broken.

(I had to set that option while trying to get rapidyaml to build on AIX.)

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #42 (9937e6d) into master (4139028) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   97.98%   97.97%   -0.01%     
==========================================
  Files          49       49              
  Lines        8222     8217       -5     
==========================================
- Hits         8056     8051       -5     
  Misses        166      166              
Impacted Files Coverage Δ
src/c4/charconv.hpp 98.24% <ø> (-0.02%) ⬇️
test/test_memory_resource.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4139028...9937e6d. Read the comment docs.

@biojppm
Copy link
Owner

biojppm commented Oct 20, 2021

Thanks for the MR. I will add fast_float-less tests to the CI; you've made me realize I haven't any.

Out of curiosity, why are you building without fast_float? Are you using your own fast_float version, or do you really want to not use it? This not to push it, it's only that I'd like to know how people are actually using c4core.

@mbs-c
Copy link
Contributor Author

mbs-c commented Oct 20, 2021

I'm trying to get rapidyaml to work on AIX 7, so I'm not a direct user of c4core (yet). Since fast_float wouldn't compile on AIX, disabling it was the easiest solution for now. Once I figure out how to patch fast_float properly, I'll probably start using it again, but since our YAML files don't contain any floats, I'm not too motivated to look into the build failures right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants