-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[impl] add riscv cpu support #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 93.96% 94.10% +0.14%
==========================================
Files 53 53
Lines 11427 11381 -46
==========================================
- Hits 10737 10710 -27
+ Misses 690 671 -19
Continue to review full report at Codecov.
|
I had trouble finding any action running on RISC-V. Was hoping you knew of one, even outside run-on-arch. Anyway, if there is no action, we'll have to stick to the old fashioned (risky) way. Have you tried this changeset yourself? That is, does this changeset enable the c4core tests to successfully run in RISC-V, or is anything else required? You can try it like this:
|
Also you can update the cmake submodule. It's not required, but makes sense since the changesets are related. |
@biojppm I find that run-on-arch has an open PR uraimo/run-on-arch-action#58 which adds support for RISC-V. But I doubt when it can be merged, sadly.
OK. I will do that soon. |
@Xeonacid thanks for the info on that RISC-V PR; was not aware of it. To merge this PR, I'm just waiting on your confirmation that this changeset runs the c4core tests in RISC-V, as described above. (The coverage test failures are spurious; everything else looks good). |
@biojppm I just ran it on Arch Linux RISC-V, and all tests passed except the ones using valgrind. (Valgrind does not support RISC-V now. 😢 ) Logs
|
Thanks @Xeonacid ! |
Since https://github.com/uraimo/run-on-arch-action doesn't support riscv currently, I'm not adding any test. I will try hard to add support for it.