Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat gcc 4.8 #74

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Compat gcc 4.8 #74

merged 1 commit into from
Feb 23, 2022

Conversation

fargies
Copy link

@fargies fargies commented Feb 22, 2022

This goes with biojppm/cmake#5

  • gcc-4.8.hpp is now part of cmake repository.
  • relevant include dir is added by c4Project.cmake when needed
  • file is installed to not require any compiler-options once deployed
  • amalgamate will also embed the file

Note: I'll override last commit once this is validated by @biojppm and cmake project has been merged

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #74 (58514bc) into master (9fd3d37) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 58514bc differs from pull request most recent head cbdd1b8. Consider uploading reports for the commit cbdd1b8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   93.96%   94.10%   +0.14%     
==========================================
  Files          53       53              
  Lines       11449    11403      -46     
==========================================
- Hits        10758    10731      -27     
+ Misses        691      672      -19     
Impacted Files Coverage Δ
src/c4/ext/fast_float_all.h 26.81% <0.00%> (-1.31%) ⬇️
src/c4/charconv.hpp 97.25% <0.00%> (-0.04%) ⬇️
test/test_memory_resource.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd3d37...cbdd1b8. Read the comment docs.

@fargies
Copy link
Author

fargies commented Feb 23, 2022

@biojppm this one should be ready now

@biojppm biojppm merged commit 4edf560 into biojppm:master Feb 23, 2022
@biojppm
Copy link
Owner

biojppm commented Feb 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants