Better predefined macros for platform detection #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://sourceforge.net/p/predef/wiki/OperatingSystems/, this is the macro specified by POSIX. This change actually fixes failure to compile on the ppc64le version of Red Hat Enterprise Linux 8. The fact that this is architecture-dependent is probably a bug in that distribution.
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 54 54
Lines 12844 12844
=======================================
Hits 12163 12163
Misses 681 681 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the full commit messages for details. This (ratther oddly) fixes failure to compile on the ppc64le version of Red Hat Enterprise Linux 8.
The
__unix__change is just for completeness/symmetry.