Intent of removing .so versions from c4core/c4log/c4fs?

[musicinmybrain]

I’ve packaged c4core, c4log, and c4fs on Fedora Linux in preparation for packaging rapidyaml (almost done!)

The change in 436b163 means that these libraries no longer have an SONAME, so I would have to either:

1. start versioning the libraries downstream (basically, carry a patch reverting this commit forever)—which is feasible—or
2. give up on packaging these libraries separately from rapidyaml—which I am permitted to do, subject to conditions, if I absolutely have to, but which has disadvantages from a distribution packager’s point of view.

Is this the intended effect of this commit? Does it solve a problem in a different environment? Can it be conditionalized such that I can turn versioning back on when packaging system copies of these libraries?

Thanks!

[musicinmybrain]

To be honest, I’m having a hard time figuring out why c4core and friends now don’t have shared library versioning when built as standalone shared libraries. When I build c4project using

/usr/bin/cmake -S . -B build -DBUILD_SHARED_LIBS:BOOL=ON --trace

it looks like

cmake/c4Project.cmake

Line 1866 in 318155d

set_target_properties(${target} PROPERTIES SO_VERSION ${${_c4_prefix}_VERSION})

is executed, but libc4core.so remains unversioned.

[biojppm]

@musicinmybrain sorry for the late reply, I missed this.

c4core and friends are definitely meant to have versioning - that's why that is done in this project, so that any lib that uses this is dealt with in the same way. I will try to figure this out.

[musicinmybrain]

c4core and friends are definitely meant to have versioning - that's why that is done in this project, so that any lib that uses this is dealt with in the same way. I will try to figure this out.

Thanks! Let me know if I can do anything to help.

[musicinmybrain]

@biojppm, did you have any luck figuring out why this was happening? Thanks!

[biojppm]

Sorry, forgot about this.

I investigated and turns out the proper name is SOVERSION rather than SO_VERSION.

I don't know how it worked before, but there it is.

[musicinmybrain]

[…] I investigated and turns out the proper name is SOVERSION rather than SO_VERSION. […]

Thanks! This now seems to work as intended.