Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include guard in the single header version #246

Closed
kamchatka-volcano opened this issue Apr 10, 2022 · 1 comment
Closed

include guard in the single header version #246

kamchatka-volcano opened this issue Apr 10, 2022 · 1 comment

Comments

@kamchatka-volcano
Copy link

Hello, isn't the include guard broken in the single header version of the library, or am I missing something?
There's is no macro #define _RYML_SINGLE_HEADER_AMALGAMATED_HPP_ anywhere and nothing stops the header from being included in translation unit multiple times. I added it on the second line and it fixed the symbol redefinition errors I was getting before.

biojppm added a commit to biojppm/cmake that referenced this issue Apr 12, 2022
biojppm added a commit to biojppm/c4core that referenced this issue Apr 12, 2022
biojppm added a commit to biojppm/c4core that referenced this issue Apr 12, 2022
@kamchatka-volcano
Copy link
Author

@biojppm Thanks! Is it possible to make a release with this fix? I'm currently relying on fetching the single header version
instead of generating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant