-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a unit test to parse 3 digits versions #302
Conversation
@ericcitaire hard to see from google/jsonnet#1014. Is it a duplicate of #292 (already fixed in master)? |
@ericcitaire I force-pushed a fix to your commit, and elaborated the tests. I don't know what is the particular problem you are having (the linked bug does not provide any context and is unclear for me), but the tests now do a successful roundtrip of multi-dot version strings, both in YAML and JSON. If the CI passes, this should be evidence that the problem is neither in ryml's parsing nor emitting. But it could be that you're using an older version where #292 is still active. |
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 97.20% 97.23% +0.02%
==========================================
Files 78 78
Lines 18072 18358 +286
==========================================
+ Hits 17567 17850 +283
- Misses 505 508 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Indeed the tests succeed (the 9 failures are unrelated). Merging now. Thanks! |
Indeed, it seems to be a duplicate of #292. Sorry, I missed it. So I guess google/jsonnet just have to rebuild with a recent version of rapidyaml. Thanks ! |
See google/jsonnet#1014