Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LazyValues #259

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Add LazyValues #259

merged 1 commit into from
Mar 9, 2023

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Feb 24, 2023

Ref. biolab/orange3#5720.

See description in the code.

Also see changes in biolab/orange-widget-base#232.

Usage example is shown in biolab/orange3#6348.

This assumes that signal manager does not check that the type of the signal matches the defined type - as is currently the case. Should it ever check this, it will have to recognize lazy signals in check their wrapped types.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 74.73% // Head: 74.79% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (c5e180e) compared to base (26b1446).
Patch coverage: 97.05% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   74.73%   74.79%   +0.06%     
==========================================
  Files          96       96              
  Lines       20621    20688      +67     
==========================================
+ Hits        15411    15474      +63     
- Misses       5210     5214       +4     
Impacted Files Coverage Δ
orangecanvas/scheme/signalmanager.py 88.57% <97.05%> (+0.57%) ⬆️
orangecanvas/gui/dock.py 79.06% <0.00%> (-0.78%) ⬇️
orangecanvas/scheme/node.py 84.76% <0.00%> (+0.63%) ⬆️
orangecanvas/scheme/readwrite.py 73.21% <0.00%> (+1.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ales-erjavec ales-erjavec merged commit 71a176f into biolab:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants