Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Translations of tests #60

Merged
merged 2 commits into from
Mar 26, 2023
Merged

SI: Translations of tests #60

merged 2 commits into from
Mar 26, 2023

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 26, 2023

Bad news:

  • We will have to run tests on translated Orange, too.
  • Just marking some tests as language-dependent won't do: there would be too many of them and I've seen bugs that we would overlook if we just skipped tests. Hence, we will need to translate tests as well.

I wanted to avoid adding strings from tests to translations because it would (almost exactly) double the file length. Therefore I've put them in a separate file, which is to be treated by different standards: the actual translations should (in principle) have no null's, while for tests nulls are OK - we only translate what is necessary.

Besides translations for tests, this PR includes some other small fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant