Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added search option to comboBox #46

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Added search option to comboBox #46

merged 1 commit into from
Mar 20, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Feb 24, 2020 •
edited
Loading

Issue

ComboBoxSearch implemented but not included in comboBox fuction.
ComboBoxSearch does not implement maximumContentsLenght, which is implemented in ComboBox.

Description of changes
  • Adding a searchable attribute to comboBox function - when True ComboBoxSearch used instead of ComboBox
  • Deprecating maximumContentsLenght for ComboBox - reason not really used in practice
  • Setting maximumContentsLenght to the default value of 25.
  • Implementing the same behavior for ComboBoxSearch (default max width 25).
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec mentioned this pull request Feb 24, 2020
Merged
3 tasks
@PrimozGodec PrimozGodec changed the title Added search option to comboBox [WIP] Added search option to comboBox Feb 27, 2020
lanzagar
lanzagar reviewed Feb 27, 2020
View reviewed changes
orangewidget/gui.py Outdated Show resolved Hide resolved
@PrimozGodec PrimozGodec force-pushed the search-combo-box branch 3 times, most recently from e788ce3 to 7a60c9f Compare February 28, 2020 11:05
@PrimozGodec PrimozGodec changed the title [WIP] Added search option to comboBox Added search option to comboBox Feb 28, 2020
@PrimozGodec PrimozGodec requested a review from lanzagar February 28, 2020 11:24
@PrimozGodec PrimozGodec force-pushed the search-combo-box branch 2 times, most recently from 2e46dde to 0207b79 Compare March 19, 2020 12:07
@lanzagar lanzagar merged commit 9eeae87 into biolab:master Mar 20, 2020
@lanzagar lanzagar mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanzagar lanzagar lanzagar left review comments

Assignees

@lanzagar lanzagar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrimozGodec @lanzagar