Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickling UDPipe #387 #447

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Pickling UDPipe #387 #447

merged 1 commit into from
Aug 27, 2019

Conversation

s-alexey
Copy link
Collaborator

@s-alexey s-alexey commented Jul 5, 2019

Issue

Even though this will fix the issue with pickling UDPipeLemmatizer the fact that Corpus.used_preprocessor is traveling around up to Network from Distances is quite suspicious.

Description of changes

updipe.Model is not compatible with pickle protocol thus should be manually loaded.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #447 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage    85.9%   85.98%   +0.08%     
==========================================
  Files          34       34              
  Lines        1937     1941       +4     
  Branches      331      331              
==========================================
+ Hits         1664     1669       +5     
+ Misses        233      232       -1     
  Partials       40       40

@ajdapretnar
Copy link
Collaborator

This no longer happens with the latest Network add-on master, but I am sure it doesn't hurt to have this handled since it avoid problems downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants