[WIP] OWSentimentAnalysis: Add new languages #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdapretnar
force-pushed
the
sentiment-langs
branch
from
f85f217 to
37079ba
Compare
|
The test passes locally. 🤷♀ |
robertcv
reviewed
Oct 15, 2019
| self.liu_hu = gui.appendRadioButton(box, "Liu Hu", addToLayout=False) | ||
| self.liu_lang = gui.comboBox(None, self, 'language', | ||
| self.liu_lang = gui.comboBox(None, self, 'liu_language', |
There was a problem hiding this comment.
Use contentsLength parameter for bouth gui.comboBox so that they are of equal length.
| self.send_signal("Corpus", self.corpus) | ||
|
|
||
| def test_output(self): | ||
| "Test if new column on the output" |
There was a problem hiding this comment.
You will probably add some testing?
ajdapretnar
force-pushed
the
sentiment-langs
branch
from
37079ba to
d542c0d
Compare
|
@robertcv Fixed. Tests still don't pass. Well, they sometimes do and sometimes don't. 🤷♀ |
|
@ajdapretnar I cannot find a solution for this falling test. I would suggest to remove it or add the skip decorator. I wouldn't like to merge something that will constantly faile. |
ajdapretnar
force-pushed
the
sentiment-langs
branch
from
d542c0d to
c46b847
Compare
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
=========================================
+ Coverage 85.57% 85.6% +0.03%
=========================================
Files 34 34
Lines 1927 2001 +74
Branches 329 336 +7
=========================================
+ Hits 1649 1713 +64
- Misses 238 248 +10
Partials 40 40 |
ajdapretnar
force-pushed
the
sentiment-langs
branch
from
c46b847 to
66d7985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements #306.
Description of changes
Add additional languages for sentiment analysis.
Includes
Todo