Document Embedder: fix default language setting #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 74.15% 74.20% +0.04%
==========================================
Files 72 72
Lines 9573 9572 -1
Branches 1305 1305
==========================================
+ Hits 7099 7103 +4
+ Misses 2226 2221 -5
Partials 248 248 |
|
Good catch! This was already solved in #701 but should have been merged sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In #565 set English as default with setting the language in the dropdown which didn't change setting correctly. So set was still the language used before. In cases when the default language was changed to English wrong embedder was used.
Description of changes
Setting English as default via default setting.
Includes