OWBaseLearner: Add reference for learner name edit

biolab · Jul 22, 2016 · 24abe42 · 24abe42
1 parent 00e694f
commit 24abe42
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/Orange/widgets/tests/base.py b/Orange/widgets/tests/base.py
@@ -1,6 +1,5 @@
 import unittest
 from collections import namedtuple
-from PyQt4 import QtGui
 
 from PyQt4.QtGui import QApplication
 import sip
@@ -259,18 +258,17 @@ def test_output_model(self):
     def test_output_learner_name(self):
         """Check if learner's name properly changes"""
         new_name = "Learner Name"
-        name_line_edit = self.widget.findChildren(QtGui.QLineEdit)[0]
         self.widget.apply_button.button.click()
-        self.assertEqual(self.widget.learner.name, name_line_edit.text())
-        name_line_edit.setText(new_name)
+        self.assertEqual(self.widget.learner.name,
+                         self.widget.name_line_edit.text())
+        self.widget.name_line_edit.setText(new_name)
         self.widget.apply_button.button.click()
         self.assertEqual(self.get_output("Learner").name, new_name)
 
     def test_output_model_name(self):
         """Check if model's name properly changes"""
         new_name = "Model Name"
-        name_line_edit = self.widget.findChildren(QtGui.QLineEdit)[0]
-        name_line_edit.setText(new_name)
+        self.widget.name_line_edit.setText(new_name)
         self.send_signal("Data", self.data)
         self.widget.apply_button.button.click()
         self.assertEqual(self.get_output(self.model_name).name, new_name)

diff --git a/Orange/widgets/utils/owlearnerwidget.py b/Orange/widgets/utils/owlearnerwidget.py
@@ -226,10 +226,10 @@ def add_main_layout(self):
         pass
 
     def add_learner_name_widget(self):
-        gui.lineEdit(self.controlArea, self, 'learner_name', box='Name',
-                     tooltip='The name will identify this model in other widgets',
-                     orientation=Qt.Horizontal,
-                     callback=lambda: self.apply())
+        self.name_line_edit = gui.lineEdit(
+            self.controlArea, self, 'learner_name', box='Name',
+            tooltip='The name will identify this model in other widgets',
+            orientation=Qt.Horizontal, callback=lambda: self.apply())
 
     def add_bottom_buttons(self):
         box = gui.hBox(self.controlArea, True)