Make TreeAdapters for Pythagorean trees more general #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.73% (diff: 100%)@@ master #1651 diff @@
==========================================
Files 78 78
Lines 8150 8150
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7232 7232
Misses 918 918
Partials 0 0
|
|
This is great, but this breaks the regression tree tooltips (which were apparently wrong and overlooked in the first place). I've opened #1660 to fix this problem, so these two should be merged together. |
|
Apologies for letting you wait; I had 11 hours of lecturing this week. I've spotted the problem with regression trees, but attributed it to some other changes I've made in another PR I'm preparing. I've merged #1660. You can now merge this one if you think it's OK. |
|
No problem. It should be okay to merge now. I've looked it over again and found no apparent problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreeAdapters are great and potentially useful elsewhere, too.
When implementing another adapter, I guess I found two (cosmetic) slips:
get_instances_in_nodesaccepts instances ofTreeNode, which is specific Pythagorean trees,ROOT_PARENTis defined as-1, which is specific to SKL trees. A value ofNonewould be more pythonic. Besides, the code in pythagorasviewer.py compares the node with-1instead of withROOT_PARENT. Finally, the constant is defined in the baseTreeAdapteras well as in the derivedSklTreeAdapter.@pavlin-policar, can you take a look at these two cosmetic changes? Did I overlook any place that needs to be changed w.r.t this?