Change default reification behavior to true to avoid tossing important qualifiers by default (like negation!) #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t qualifiers by default (like negation!)
|
We should definitely include all edge properties by default! The choice of flag name is a bit odd. I would expect if reificiation is True, then reification is used: i. SPO only and nodes generated for edge properties |
|
Thanks for this PR - I'd also expect to see all properties in the RDF transforms. |
|
@cmungall Would it make sense to simplify the flag to just @caufieldjh I haven't seen any documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ian from CPATH noticed that the rdf version of monarch-kg's ingest transforms only had the basic triples and no properties, after digging I saw that reification is set to false by default. I think it makes sense to default to reification being true, since otherwise it's not really a full transformation of the original source.