Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For #2108 #670

Merged
merged 2 commits into from
Mar 27, 2024
Merged

For #2108 #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6393dd5
For #2108
mugitty Mar 26, 2024
b0e7bdd
For #2108
mugitty Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ travis_test:
tests/test_validation_rules.py tests/unit/test_annotation_scorer.py \
tests/test_goassociation_model.py tests/test_relations.py \
tests/unit/test_golr_search_query.py tests/unit/test_owlsim2_api.py \
tests/unit/test_clinical_mod.py tests/test_collections.py \
tests/test_collections.py \
tests/test_gocamgen.py

cleandist:
Expand Down
2 changes: 1 addition & 1 deletion ontobio/io/qc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@ def test(self, annotation: association.GoAssociation, config: assocparser.AssocP
class GoRule63(GoRule):

def __init__(self):
super().__init__("GORULE:0000063", "Annotations using ISS/ISA/ISO evidence should refer to a gene product (in the 'with' column)", FailMode.HARD)
super().__init__("GORULE:0000063", "Annotations using ISS/ISA/ISO evidence should refer to a gene product (in the 'with' column)", FailMode.SOFT)

def test(self, annotation: association.GoAssociation, config: assocparser.AssocParserConfig, group=None) -> TestResult:
evidence = str(annotation.evidence.type)
Expand Down
6 changes: 3 additions & 3 deletions tests/test_qc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,17 +764,17 @@ def test_go_rule_63():
# ISS with nothing in withfrom
assoc = make_annotation(evidence="ISS", withfrom="").associations[0]
test_result = qc.GoRule63().test(assoc, all_rules_config())
assert test_result.result_type == qc.ResultType.ERROR
assert test_result.result_type == qc.ResultType.WARNING

# ISA with with nothing in withfrom
assoc = make_annotation(evidence="ISA", withfrom="").associations[0]
test_result = qc.GoRule63().test(assoc, all_rules_config())
assert test_result.result_type == qc.ResultType.ERROR
assert test_result.result_type == qc.ResultType.WARNING

# ISO with with nothing in withfrom
assoc = make_annotation(evidence="ISO", withfrom="").associations[0]
test_result = qc.GoRule63().test(assoc, all_rules_config())
assert test_result.result_type == qc.ResultType.ERROR
assert test_result.result_type == qc.ResultType.WARNING

def test_all_rules():
# pass
Expand Down
Loading