Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For #2273 Fix path #673

Merged
merged 1 commit into from
Mar 29, 2024
Merged

For #2273 Fix path #673

merged 1 commit into from
Mar 29, 2024

Conversation

mugitty
Copy link
Collaborator

@mugitty mugitty commented Mar 29, 2024

No description provided.

@mugitty mugitty requested a review from dustine32 March 29, 2024 00:19
@dustine32
Copy link
Collaborator

Thanks @mugitty! I'm actually running a local test of go-site-2273-path-fix with validate.py rule and produce right now and then will review if it succeeds. Quality control!

dustine32
dustine32 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mugitty Thanks for the quick fix! I confirmed that running rule and produce locally do not err out.

@dustine32
Copy link
Collaborator

@mugitty Merge away!

@mugitty
Copy link
Collaborator Author

mugitty commented Mar 29, 2024

Thanks for reviewing and testing

@mugitty mugitty merged commit a68a625 into master Mar 29, 2024
5 checks passed
@mugitty mugitty deleted the go-site-2273-path-fix branch May 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugitty @dustine32