Fix M3U playlist abort #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the webstream connects but is redirected to a 404 page, we should not abort the playlist but jump to the next entry.
tueddy
added a commit
that referenced
this pull request
Dec 9, 2023
tueddy
pushed a commit
that referenced
this pull request
Jan 2, 2024
…f0b078 (#285) Some properties like repeatCurrentTrack, repeatPlaylist, sleepAfterCurrentTrack, sleepAfterPlaylist, saveLastPlayPosition got lost with af0b078 See also https://forum.espuino.de/t/3-bugs-in-audioplayer-cpp-hoerbuchmodus-speichern-der-playposition-sleepafter/2456/3?u=sfields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where the playlist was aborted. This happens when we encounter an errorous link which gets redirected to a 404 page by the server. Since the connection got successfully etablished, but we get no audio stream, we aborted the whole playlist.
This commit introduces a (currently) hardcoded timeout of 2s. If we do not get a working audio stream until then, after which we jump to the next title.