-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #10
Update README.md #10
Conversation
First commit with initial changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
I really dig the badges!
I left some suggestions.
The usage section could be similar to the one in biome-vscode, where we tell the users how to format their code (with keyboard shortcuts), for example. |
Co-authored-by: Nicolas Hedger <649677+nhedger@users.noreply.github.com>
@nhedger i really appreciatte your last suggestions, and i've already implemented them. And i hope i did well. Let me know if anything i can improve in this task. |
Co-authored-by: Nicolas Hedger <649677+nhedger@users.noreply.github.com>
Hey, I haven't had time to review the changes yet. Hopefully this weekend or next week. |
Ok, @nhedger I didn't mean to rush you. This is my first contribution to a project, and i am new as a dev, so sometimes I'm unsure about how to proceed. Please take the time you need. |
Include 💾 Automatically format code on save" in the features list.
Hi @andreluiz901 , is there anything missing? Can we make this ready for merge? |
Hello, @ematipico. I made some changes, i think thats for me its good to merge. However, I dont know if someone wants to review anymore. If not, i think we are good to go. What you say? |
The PR is still in draft, so I assume you're still working on it. If not, then it should be ready for review right? |
Yes, @ematipico i am already done here. So, should i mark "ready for review"? I was not marked yet because some people requested changes. But, now its good to go. |
It seems there are conflicts, could you please resolve them and the you can mark as ready? |
Of course, @nhedger , i will work right now. |
I think everything should be good now. If need something to change or any other actions, just say. |
Thanks for you contribution @andreluiz901 ! |
I really appreciate @nhedger and everyone. Thanks for the oportunity, thats my first contrubution in a real project. It was a great experience. I am relative new as a developer, but i hope soon i will continue to contribute even more on other projects. Thanks again for the patience and to show me how everything works. See you all, |
First commit with initial changes.