Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10

Merged
merged 8 commits into from
Feb 14, 2024
Merged

Update README.md #10

merged 8 commits into from
Feb 14, 2024

Conversation

andreluiz901
Copy link
Contributor

First commit with initial changes.

First commit with initial changes.
@andreluiz901 andreluiz901 mentioned this pull request Dec 16, 2023
Copy link
Member

@nhedger nhedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

I really dig the badges!

I left some suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nhedger
Copy link
Member

nhedger commented Dec 17, 2023

The usage section could be similar to the one in biome-vscode, where we tell the users how to format their code (with keyboard shortcuts), for example.

@andreluiz901
Copy link
Contributor Author

@nhedger i really appreciatte your last suggestions, and i've already implemented them.

And i hope i did well.

Let me know if anything i can improve in this task.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Hedger <649677+nhedger@users.noreply.github.com>
@andreluiz901
Copy link
Contributor Author

Hello again, @nhedger. I did the last suggestions and modifications. And im thinking if have any other suggestions or work to finish this issue?
Also, I was reading the doc and did not found anything about biome-intellij to insert or any more improvements.

@nhedger
Copy link
Member

nhedger commented Dec 21, 2023

Hello again, @nhedger. I did the last suggestions and modifications. And im thinking if have any other suggestions or work to finish this issue?

Also, I was reading the doc and did not found anything about biome-intellij to insert or any more improvements.

Hey, I haven't had time to review the changes yet. Hopefully this weekend or next week.

@andreluiz901
Copy link
Contributor Author

Ok, @nhedger I didn't mean to rush you. This is my first contribution to a project, and i am new as a dev, so sometimes I'm unsure about how to proceed. Please take the time you need.

Include 💾 Automatically format code on save" in the features list.
@ematipico
Copy link
Member

Hi @andreluiz901 , is there anything missing? Can we make this ready for merge?

@andreluiz901
Copy link
Contributor Author

Hi @andreluiz901 , is there anything missing? Can we make this ready for merge?

Hello, @ematipico. I made some changes, i think thats for me its good to merge. However, I dont know if someone wants to review anymore. If not, i think we are good to go. What you say?

@ematipico
Copy link
Member

The PR is still in draft, so I assume you're still working on it. If not, then it should be ready for review right?

@andreluiz901
Copy link
Contributor Author

Yes, @ematipico i am already done here. So, should i mark "ready for review"? I was not marked yet because some people requested changes. But, now its good to go.

@nhedger
Copy link
Member

nhedger commented Feb 14, 2024

Yes, @ematipico i am already done here. So, should i mark "ready for review"? I was not marked yet because some people requested changes. But, now its good to go.

It seems there are conflicts, could you please resolve them and the you can mark as ready?

@andreluiz901
Copy link
Contributor Author

Of course, @nhedger , i will work right now.

@andreluiz901 andreluiz901 marked this pull request as ready for review February 14, 2024 15:29
@andreluiz901
Copy link
Contributor Author

I think everything should be good now. If need something to change or any other actions, just say.

@nhedger nhedger merged commit 85a2810 into biomejs:main Feb 14, 2024
1 check passed
@nhedger
Copy link
Member

nhedger commented Feb 14, 2024

Thanks for you contribution @andreluiz901 !

@andreluiz901
Copy link
Contributor Author

I really appreciate @nhedger and everyone. Thanks for the oportunity, thats my first contrubution in a real project. It was a great experience. I am relative new as a developer, but i hope soon i will continue to contribute even more on other projects.

Thanks again for the patience and to show me how everything works.

See you all,
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants