Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onSave actions #3

Merged
merged 4 commits into from
Dec 22, 2023
Merged

feat: add onSave actions #3

merged 4 commits into from
Dec 22, 2023

Conversation

victor-teles
Copy link
Contributor

@victor-teles victor-teles commented Dec 15, 2023 •
edited
Loading

Summary

This PR introduces some improvements to the IntelliJ plugin:

  • Support for format on save
  • Support for safe fixes on save
  • Support for unsafe fixes on save
  • Added native reformat with LSP
  • Support for file filtering with glob pattern
  • Format file with ctrl alt shift P/meta alt shift P (same as prettier plugin to make less impact for users that are migrating to Biome)
  • Revamp configuration mode (disabled, automatic configuration, and manual configuration)

Sorry for the huge amount of changes 😅

Automatic configuration mode

CleanShot 2023-12-19 at 19 06 44@2x

Manual configuration mode

CleanShot 2023-12-19 at 19 07 33@2x

Test Plan

Test saving actions
I'm planning to add UI testing later

@victor-teles victor-teles mentioned this pull request Dec 15, 2023
Closed
@victor-teles victor-teles force-pushed the feature/onSaveFeatures branch 4 times, most recently from f9c76ca to 6d9ae1c Compare December 19, 2023 22:11
@victor-teles victor-teles marked this pull request as ready for review December 20, 2023 15:22
@victor-teles victor-teles merged commit a632d90 into biomejs:main Dec 22, 2023
1 check passed
@victor-teles victor-teles deleted the feature/onSaveFeatures branch December 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@nissy-dev nissy-dev Awaiting requested review from nissy-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victor-teles @ematipico