-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate biome.json path config #32
feat: validate biome.json path config #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure how this is going to work, but users should just pass a file name, but only the directory where the configuration is. Biome will do the rest
companion object { | ||
const val configName = "biome.json" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this will work in the long run. Once we allow biome.jsonc
as a configuration file format, this will be outdated and will require a new version.
I'm not sure it's worth it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'll update to a more flexible approach
@ematipico You mean there's no need to validate the input? Just to give you some context: To fix this i now just pass the parent path: |
Thank you, it wasn't clear from the PR description |
This PR closes #5.