allow intellij project to work with different biome configs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
reviewed
Apr 22, 2024
src/main/kotlin/com/github/biomejs/intellijbiome/listeners/BiomeEditorPanelListener.kt
Show resolved
Hide resolved
| class BiomeLspServerManagerListener(val project: Project) : LspServerManagerListener { | ||
| override fun serverStateChanged(lspServer: LspServer) { | ||
| if (lspServer.descriptor is BiomeLspServerDescriptor && lspServer.state == LspServerState.ShutdownUnexpectedly) { | ||
| // restart again if the server was shutdown unexpectedly. |
…kin/biome-intellij into feature/allow-multiple-biome-conf
ematipico
approved these changes
Apr 24, 2024
|
@ematipico curious, when this will be merged/published? |
|
@APshenkin, your PR was merged, and your changes should be available in version 1.1.0 of the plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I really liked the speed and easy use of biome. But unfortunately without pretty support in IDE it's really hard to bring it to my company now. So I tried to solve current issues, that block.
Reformat with Biome Plugin does not work #44
The problem is that in case if file wasn't saved first, it was deleted entirely. Also I think it should be valid to use all options (applySafeFixesOnSave, applyUnsafeFixesOnSave) when Reformat with Biome is triggered, cause this is something that everyone expect.
Biome plugin in intellij not respecting settings in biome.json #42
This is done for Automatic setup. I didn't come up with something better, that lookup to biome config from file upwards the project root. So it will use this file as config for formatting and LSP then. LSP will restart, if editor will be focused on newfile that will have different biome config. I saw this issue in main biome 📎 LSP: support for Workspaces biome#1573. But currently LSP proxy is not supporting workspaces. Also for me workspaces looks less flexible, as for example I can specify several biome conf now in one workspace (let's say for different folders for some reasons). Also as in large codebases there could be the case, that biome will be enabled not on root level, I stop LSP in cases, if there is no biome config. Otherwise it can create noise to some other projects within your workspace.