Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use lsp settings to configure custom biome binary #19

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

luckydye
Copy link
Collaborator

Closes #18

With this PR the biome binary used by the extension can be configured in the zed settings like this:

{
  "lsp": {
    "biome": {
      "binary": {
        "path": "~/biome/target/debug/biome",
        "arguments": ["lsp-proxy"]
      }
    }
  } 
}

Then the logs will print something like the following:

2024-05-28T01:11:04+02:00 [INFO] starting language server. binary path: "~/biome/target/debug/biome", working directory: "<project>", args: ["lsp-proxy"]

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the contribution guide with an example of how a developer can set it up?

@ematipico ematipico merged commit b28e3c6 into main Jun 6, 2024
2 checks passed
@ematipico ematipico deleted the feat/lsp-settings branch June 6, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using a custom Biome binary for development
2 participants